Segmentation fault when using array [duplicate]

Question

#include <stdio.h>

typedef struct StockDetail {
    char* name;
    int code;
    int price;

} Stock;

int main(void)
{
    Stock a[200]; int i; int b;
    for(i=0; i<20 ; i++ )
    {
        printf("Stock %i\n",i+1);
        printf("Name:");
        scanf("%s",a[i].name);
        printf("Code:");
        scanf("%i",&a[i].code);
        printf("Name:");
        scanf("%i",&a[i].price);

    }

    printf("Maximum price of the stock:");
    scanf("%i", &b);

    for(i=0; i<20 ; i++)
    {
        if(a[i].price<=b)
        {
            printf("%s\n",a[i].name);
        }
    }
}

Hi, I'm trying to implement a program that reads 20 stock details such as name, code and price and then ask the user to input a maximum price and print out the stock that cost less than the price. The code looks fine but when I tried to run it gave "segmentation fault" error line.

Next time try to produce a minimal reproducible example! there are more lines that are not executed than there are lines that actually are. — Antti Haapala
– Antti Haapala, Commented Nov 14, 2017 at 7:19

LoztInSpace · Accepted Answer · 2017-11-14 04:18:47Z

7

You do not allocate any space for your Stock.name. Use a char[100] or allocate some space.

something like:

for(i=0; i<20 ; i++ )
{
    char tempname[100];
    printf("Stock %i\n",i+1);
    printf("Name:");
    scanf("%s",tempname);
    a[i].name=strdup(tempname);

Don't forget to free it!

Otherwise declare

typedef struct StockDetail {
char name[100];
int code;
int price;

} Stock;

edited Nov 14, 2017 at 4:18

answered Nov 14, 2017 at 4:11

LoztInSpace

5,6971 gold badge17 silver badges29 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Pras · Accepted Answer · 2017-11-14 04:10:27Z

4

scanf("%s",a[i].name);

Here you are taking input in name which is just char* it does not have memory alloted to it, you can declare it as char array with sufficient size or allocate memory with malloc before taking input in it

answered Nov 14, 2017 at 4:10

Pras

4,03612 silver badges21 bronze badges

Collectives™ on Stack Overflow

Segmentation fault when using array [duplicate]

2 Answers 2

Comments

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Linked

Related