Angular 4 -> push to array

Question

Need assistance pushing new cards when the "Hit" button is selected to the cards[] array. I've tried a myriad of methods but can't seem to nail this simple issue. Assistance is greatly valued!

      @Component({
      selector: 'app-root',
      templateUrl: './app.component.html',
      styleUrls: ['./app.component.css']
      })
      export class AppComponent {
      title = 'app';
      deck: any;
      cards = [];
      hand = 0;
      cardCount: number;

      constructor(private _data: DataService){
        console.log("Data Service ready to query api");
        this.cards = [];
      };


      newDeck(){
            this._data.newDeck().subscribe(res => this.deck = res.json());

      }

      deal(cardCount){

        this._data.deal(cardCount, this.deck.deck_id).subscribe(response => this.cards = response.json());
        if(this.cards) {
          this.cards.push(this.cards);
        }
      }

  }

komron · Accepted Answer · 2017-11-04 07:07:57Z

2

Your approach is wrong , because:

When you receive response you reassign response.json to this.cards
When your deal method gets called it simply subscribes, and then pushes this.cards array into itself if the condition this.cards is true.

deal(cardCount)
    {
            this._data.deal(cardCount, this.deck.deck_id).subscribe(response => { 
                           const cards = response.json() 
                           if(cards) {
                               this.cards.push(cards);
                           }
    });

edited Nov 4, 2017 at 7:07

answered Nov 4, 2017 at 7:02

komron

2,2773 gold badges19 silver badges27 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Dhyey · Accepted Answer · 2017-11-04 07:32:23Z

0

You need to put the code inside subscribe, as it is asynchronous

deal(cardCount){
    this._data.deal(cardCount, this.deck.deck_id).subscribe(response => 
        if(response) {
            this.cards.push(response.json());
        }
    );
}

edited Nov 4, 2017 at 7:32

answered Nov 4, 2017 at 5:59

Dhyey

4,3453 gold badges28 silver badges34 bronze badges

1 Comment

Chris Simmons Over a year ago

Hey! I tried this as well but I receive error -> ERROR TypeError: _this.cards.push is not a function

Collectives™ on Stack Overflow

Angular 4 -> push to array

2 Answers 2

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related