this c program is not giving correct output.(to convert number string to integer) [duplicate]

Question

this is c program to convert number string into integer. I think that the if statement is not getting executed. I want to compare string[a] with the ascii value representented by number in integer i.

    //to convert number string to integer
#include<stdio.h>
#include<string.h>
void main()
{
    int a=0, copy[10]={0},len,i;
    char string[10];
    clrscr();
    puts("enter a number string");
    gets(string);
    len=strlen(string);
    while(a<len)
    {
        for(i=48;i<=57;i++)
        {
            if(string[a]==i)
            {
                copy[a]=i-48;
                break;
            }
            a++;
        }

    }
    for(i=0;i<len;i++)
    printf("%d",copy[i]);
    getch();
}

Hints: 1. don't use TurboC, 2. gets has been deprecated more than a decade ago. 3. Don't use "magic numbers" such as 48 but use '0' instead. — Jabberwocky
– Jabberwocky, Commented Nov 3, 2017 at 8:35

Amarjit Singh · Accepted Answer · 2017-11-03 08:44:36Z

1

The problem is near break statement, Your break statement is being executed without executing a++;. Here is the correct code.

#include<stdio.h>
#include<string.h>
void main()
{
    int a=0, copy[10]={0},len,i;
    char string[10];
    clrscr();
    puts("enter a number string");
    gets(string);
    len=strlen(string);
    while(a<len)
    {
        for(i=48;i<=57;i++)
        {
            if(string[a]==i)
            {
                copy[a]=i-48;
                a++;
                break;
            }
        }

    }
    for(i=0;i<len;i++)
    printf("%d",copy[i]);
    getch();
}

answered Nov 3, 2017 at 8:44

Amarjit Singh

2,1541 gold badge25 silver badges55 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

this c program is not giving correct output.(to convert number string to integer) [duplicate]

1 Answer 1

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Linked

Related