Using a Boolean Expression in a StringBuilder

Question

I'm using a string builder to build some SQL Scripts. I have a few Boolean Properties that I would like to test and then output different text based on true/false. I've you the C# syntax below when assigning a value to a variable, but it isn't working for this particular situation. Any ideas?

What I'm used to doing:

string someText = (dbInfo.IsIdentity) ? "First Option" : "Second Option";

Trying to duplicate the same thing inside a StringBuilder method, but this isn't working..

script.Append("sometext" + (dbInfo.IsIdentity) ? " IDENTITY(1,1)" : "");

Michael Borgwardt · Accepted Answer · 2009-01-22 18:11:30Z

8

Add parentheses:

script.Append("sometext" + ((dbInfo.IsIdentity) ? " IDENTITY(1,1)" : ""));

answered Jan 22, 2009 at 18:11

Michael Borgwardt

347k81 gold badges491 silver badges726 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Greg · Accepted Answer · 2009-01-22 18:13:15Z

4

What about this?

script.Append( "sometext" );
script.Append( dbInfo.IsIdentity ? " IDENTITY(1,1)" : "" );

answered Jan 22, 2009 at 18:13

Greg

16.7k9 gold badges55 silver badges100 bronze badges

Comments

Kev · Accepted Answer · 2009-01-22 18:15:11Z

3

Extra parenthesis or even nicer use AppendFormat

script.AppendFormat("sometext{0}", dbInfo.IsIdentity ? " IDENTITY(1,1)" : "");

answered Jan 22, 2009 at 18:15

Kev

120k53 gold badges308 silver badges396 bronze badges

Comments

Sergio · Accepted Answer · 2009-01-22 18:23:44Z

3

Other from stating that if you have a stringbuilder you should use it to concatenate strings.

That said, the code bellow should work.

script.Append("sometext");
script.Append(dbInfo.IsIdentity ? " IDENTITY(1,1)" : "");

In this particular case you could also do:

script.Append("sometext");
if(dbInfo.IsIdentity) script.Append(" IDENTITY(1,1)");

edited Jan 22, 2009 at 18:23

answered Jan 22, 2009 at 18:14

Sergio

8,31510 gold badges50 silver badges77 bronze badges

Comments

Scott Muc · Accepted Answer · 2009-01-22 18:11:56Z

2

Just a hunch but I think you need some more brackets:

script.Append("sometext" + ((dbInfo.IsIdentity) ? " IDENTITY(1,1)" : ""));

I would urge you to use a temporary variable for readability sake.

answered Jan 22, 2009 at 18:11

Scott Muc

2,88328 silver badges38 bronze badges

Comments

Matthew Brubaker · Accepted Answer · 2009-01-22 18:12:21Z

0

First, I would try wrapping the if/then/else in a set of parenthesis and see if that fixes the problem. It may be a problem with the order in which that expression is being evaluated.

answered Jan 22, 2009 at 18:12

Matthew Brubaker

3,1171 gold badge22 silver badges18 bronze badges

Comments

orip · Accepted Answer · 2009-01-22 18:16:53Z

0

A quick suggestion: if you're generating SQL like this, you may have a better time using a templating like StringTemplate to generate it vs. using straight C#.

answered Jan 22, 2009 at 18:16

orip

76k21 gold badges120 silver badges150 bronze badges

Collectives™ on Stack Overflow

Using a Boolean Expression in a StringBuilder

7 Answers 7

Comments

Comments

Comments

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

7 Answers 7

Comments

Comments

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related