Javascript: For loop in a for loop

Question

I'm doing a scoring app as practice, and I'm trying to get an object to calculate the total score for a player. Here is the part I'm struggling with:

totalScore: function () {
  "use strict";
  debugger;
  var sum = 0;
  for (var i = 0; i < this.players[i].length; i++) {
    for (var n = 0; n < this.players[i].score[n].length; n++) {
      sum += this.players[i].score[n];
    }
    this.players[i].totalScore = sum;
  }  }

So I have a main object scoreTable. players is an array of objects which includes another array called score. So what I'm trying to do is create a totalScore object function that runs a loop through the players array that loops on each score array and finds the sum of that array.

I don't know why, but when I run through it on the dubugger, it goes into the first for loop, finds the first array of players, then just skips to the end of the function without running the next loop. I'm not sure why it's doing that.

I bet sum must be inside the loop.

Jonas Wilms
– Jonas Wilms

2017-10-09 18:31:30 +00:00
Commented Oct 9, 2017 at 18:31 — Jonas Wilms
– Jonas Wilms, Commented Oct 9, 2017 at 18:31

Kenji Mukai · Accepted Answer · 2017-10-09 18:32:00Z

3

for (var i = 0; i < this.players[i].length; i++) {
    for (var n = 0; n < this.players[i].score[n].length; n++) 
}

This should be:

for (var i = 0; i < this.players.length; i++) {
    for (var n = 0; n < this.players[i].score.length; n++) 
}

edited Oct 9, 2017 at 18:32

answered Oct 9, 2017 at 18:29

Kenji Mukai

5994 silver badges8 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

corn3lius Over a year ago

and the next for loop too score.length

dhilt · Accepted Answer · 2017-10-09 18:39:01Z

0

Try following:

totalScore: function () {
    for (var i = 0; i < this.players.length; i++) {
        var player = this.players[i];
        player.totalScore = 0;
        for (var n = 0; n < player.score.length; n++) {
          player.totalScore += player.score[n];
        }
    }
}

This fixes not only syntax errors, but also the sum-logic itself: sum variable from initial post won't reset for each new player in the top-level loop.

edited Oct 9, 2017 at 18:39

answered Oct 9, 2017 at 18:33

dhilt

21.1k8 gold badges79 silver badges96 bronze badges

Collectives™ on Stack Overflow

Javascript: For loop in a for loop

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related