Problem converting integer to ASCII code in x86 assembly

Question

I am trying to use the code below to convert an integer in ax to ASCII codes. But running it outputs 515, rather than 513 as I expected. Where is the error?

stk segment
    dw 32 dup(0)
stk ends
dts Segment
    posnum db 6 dup(0) ;0<x<65536;
dts ends
cds Segment
    Assume cs:cds , ds:dts,ss:stk
    Main Proc Far

     mov ax,seg dts
     mov ds,ax
     mov es,ax
     xor ax,ax

     mov ax,513

     mov di,offset posnum

     Call ConvertPositive

     mov ah,09h
     mov dx ,offset posnum
     int 21h
    main_finish:
        mov ah,08h
        int 21h
        mov ax,4c00h
        int 21h
    Main endp
cds Ends

procs segment
    assume cs:procs
    ConvertPositive proc far
        xor dx,dx
        xor cx,cx
        mov bl,10
        mov bh,0
        divloop:
            mov dx,0
            div bx
            add dl,30h
            mov byte ptr [si],dl
            inc cl
            inc si
            cmp ax,0
            jne divloop
        enddiv:
            dec si
            copy:
                std
                LODSB
                cld
                STOSB   
            loop copy
            mov byte ptr [di],'$'
        ret
    ConvertPositive endp
procs ends
end Main

Jester · Accepted Answer · 2011-01-09 18:28:51Z

1

SI is not initialized. It should point to a buffer allocated for the reverse order digits.

answered Jan 9, 2011 at 18:28

Jester

59.4k4 gold badges89 silver badges131 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Earlz · Accepted Answer · 2012-12-07 20:53:22Z

0

Your divide loop looks good

#include <stdio.h>
#include <stdlib.h>
#include <string.h>

 int main ( void )
 {
     unsigned int ax;
     unsigned int dx;

     ax=513;

     while(ax)
     {
        dx=ax%10;
        ax=ax/10;
        printf("%c",dx+0x30);
     }
     printf("\n");
 }

I get 315 out of the above loop.

I suspect when you try to flip the string around your 5 is stomping on your 3. Try a number like 713 and see if it results in 717. 523 if you get 525, etc. I am guessing 1234 results in 4334.

edited Dec 7, 2012 at 20:53

Earlz

64.3k100 gold badges314 silver badges511 bronze badges

answered Jan 9, 2011 at 15:51

old_timer

72.2k9 gold badges104 silver badges180 bronze badges

1 Comment

Earlz Over a year ago

Er, apologies. Didn't realize this was an old answer

Collectives™ on Stack Overflow

Problem converting integer to ASCII code in x86 assembly

2 Answers 2

Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related