Converting an asynchronous function to synchronous in node js?

Question

I am working with an API which expects me to pass the first four digits of a card and it returns me the card country. Now, here is my problem. It turns out that the function that I am calling is asynchronous and when I try to return the country, it actually goes to the return value before even the async call is fully executed. I wanted the call to be synchronous which means I dont want the function to return me the default data and wait for the actual response from the API. This is what I tried so far. I actually used console.log() statement to figure out the whole problem.

module.exports = {
  bvncheck: function (cardnum) {
    console.log("cardnumber", cardnum);
    flutterwave.BIN.check(cardnum, function (req, res) {
      var country = res.body.data.country;
      console.log("country", country);
      return country;
    });
  }


};

app.post('/checkcardbin', function (req, res) {
  var cardnumber = req.body.cardnumber;

  //var r = fd.bvncheck(cardnumber);

  var r = fd.bvncheck(cardnumber);
  console.log("result", r);
});

I expected the following output in the following order-

1. cardnumber *****
2. country  *****
3. result ******

But in reality, it is returning me in the following order and due to the asynchronous nature, I am getting result to be undefined because the data is returned before the function is actually done executing.

1. cardnumber *****
2. result ******
3. country *****

How can I solve this issue? Any suggestions or advise is highly appreciated.

"Convert asynchronous stuff to synchronous" on a single-threaded engine = very bad idea. Embrace asynchronism and learn how to deal with it = very good idea. — Jeremy Thille
– Jeremy Thille, Commented Aug 3, 2017 at 12:01

navjotdhanawat · Accepted Answer · 2017-08-03 12:15:59Z

3

I had to change your module by including callback. So that fd.bvncheck will wait for the callback.

module.exports = {
        bvncheck: function (cardnum, callback) {
            console.log("cardnumber", cardnum);
            flutterwave.BIN.check(cardnum, function (req, res) {
                var country = res.body.data.country;
                console.log("country", country);
                callback(country);
            });
        }
    }
    app.post('/checkcardbin', function (req, res) {
        var cardnumber = req.body.cardnumber;

        //var r = fd.bvncheck(cardnumber);

        fd.bvncheck(cardnumber, function(r) {
            console.log("result", r);
        });

    });

answered Aug 3, 2017 at 12:15

navjotdhanawat

3331 gold badge4 silver badges13 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Aniket Bhange · Accepted Answer · 2017-08-03 12:09:16Z

1

You can use promise fro that

module.exports = {
  bvncheck: function(cardnum) {
    return new Promise(function(resolve, reject){
      flutterwave.BIN.check(cardnum, function(req,res){
        var country = res.body.data.country;
        resolve({country:country, cardnumber: cardnum});
      });
    });
}

app.post('/checkcardbin',function(req,res){
  var cardnumber = req.body.cardnumber;
  fd.bvncheck(cardnumber).then(function(v){
    console.log(v);
  });
});

answered Aug 3, 2017 at 12:09

Aniket Bhange

915 bronze badges

Comments

Harry · Accepted Answer · 2017-08-03 12:02:18Z

1

You can use Promise.all. Here is a good explanation: https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Global_Objects/Promise/all

answered Aug 3, 2017 at 12:02

Harry

5291 gold badge5 silver badges13 bronze badges

Comments

Jed Richards · Accepted Answer · 2017-08-03 12:17:44Z

The bvncheck function isn't written properly. It's async but it doesn't provide a way to pass in a callback. As it's currently written there's no way to access the returned country from outside the bvncheck function. That return country; line is doing nothing of any value. It should look more like this,

module.exports = {
  bvncheck: function(cardnum, callback) {
    console.log('cardnumber', cardnum);
    flutterwave.BIN.check(cardnum, function(req, res) {
      var country = res.body.data.country;
      console.log('country', country);
      callback(country);
    });
  },
};

Note the new callback parameter that gets passed in, and then called with the country value (instead of just returning it nowhere).

Use it like this,

app.post('/checkcardbin', function(req, res) {
  var cardnumber = req.body.cardnumber;
  fd.bvncheck(cardnumber, function(country) {
    var r = country;
    console.log('result', r);
  });
});

Collectives™ on Stack Overflow

Converting an asynchronous function to synchronous in node js?

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related