php Function echo's wrong string

Question

I'm fairly new to PHP so forgive me if this function is badly done.

I have a function:

function socialLink($sm_type = NULL) {
   if ($sm_type = 'twitter') {
     echo 'https://www.twitter.com';
   } else {
     echo 'https://www.facebook.com';
   }
}

In my code when I call the function socialLink('facebook'); it echo's the Twitter URL.

Surely it should echo the Facebook URL since $sm_type would be equal to 'facebook' not twitter ?

Any help would be appreciated.

your test is a classic error : should be $sm_type == 'twitter'. As written, you assigne a value to $sm_type, always true. — YvesLeBorg
– YvesLeBorg, Commented Jul 21, 2017 at 11:31
Make sure that you read proper documentation about the Comparison Operators (in any programming language): php.net/manual/en/language.operators.comparison.php — Nikhil
– Nikhil, Commented Jul 21, 2017 at 11:32
Thank you for the link. I could definitely do with revising more of the PHP Manual. — regen
– regen, Commented Jul 21, 2017 at 11:36

Virb · Accepted Answer · 2017-07-21 11:31:43Z

5

Set your if condition with this,

function socialLink($sm_type = NULL) {
   if ($sm_type == 'twitter') {
     echo 'https://www.twitter.com';
   } else {
     echo 'https://www.facebook.com';
   }
}

See this.

answered Jul 21, 2017 at 11:31

Virb

1,5781 gold badge16 silver badges25 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

regen Over a year ago

It was something so simple all along. Can't believe I couldn't see that. Thank you.

Virb Over a year ago

Happy to help dude. Be careful for small mistakes. Please accept the answer if you got your output.. Cheerss..!!

RïshïKêsh Kümar · Accepted Answer · 2017-07-21 11:33:24Z

3

function socialLink($sm_type = NULL) {

   if ($sm_type == 'twitter') {
     echo 'https://www.twitter.com';
   } else {
     echo 'https://www.facebook.com';
   }
}

NOTE: Single = use to assign the value and = = use to compare values

Different's Between = , = = , = = =

= operator Used to just assign the value.
= = operator Used to just compares the values not datatype
= = = operator Used to Compare the values as well as datatype.

answered Jul 21, 2017 at 11:33

RïshïKêsh Kümar

5,0621 gold badge27 silver badges38 bronze badges

Comments

BenRoob · Accepted Answer · 2017-07-21 11:31:42Z

2

Your if statement does not use a comparison operator, it is an assignment (=). For a comparison, please use "==".

if ($sm_type == 'twitter') {
     echo 'https://www.twitter.com';
} else {
    echo 'https://www.facebook.com';
}

answered Jul 21, 2017 at 11:31

BenRoob

1,7225 gold badges22 silver badges26 bronze badges

1 Comment

regen Over a year ago

It was something so simple all along. Can't believe I couldn't see that. Thank you.

Puja · Accepted Answer · 2017-07-21 11:38:33Z

2

if ($sm_type == 'twitter') {
 echo 'https://www.twitter.com';
} else {
echo 'https://www.facebook.com';
}

In php == is use for string comparison so, In this case you can't used = for that, simple :)

answered Jul 21, 2017 at 11:38

Puja

4612 gold badges6 silver badges21 bronze badges

Collectives™ on Stack Overflow

php Function echo's wrong string

4 Answers 4

2 Comments

Comments

1 Comment

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

2 Comments

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related