Javascript integer to time string

Question

I had this test:

Implement an function toReadableString(int) that takes an integer that represents number of seconds
from 00:00:00 and returns a printable string format with AM / PM notation.
For ex.
01:00:00 = 3600
07:00:00 = 25200
toReadableString(3600) should return "1:00AM"
toReadableString(25200) should return "7:00AM"

And my solution is:

function padZero(string){
  return ("00" + string).slice(-2);
}
function toReadableString(time) {
  var hrs = ~~(time / 3600 % 24),
      mins = ~~((time % 3600) / 60),
      timeType = (hrs>11?"PM":"AM");
  return hrs + ":" + padZero(mins) + timeType;
}

But it fails most of test cases. The test cases are hidden, so I don't know why i failed the test. I have tried most of the test cases I could think of. Any ideas what's wrong with my solution?

@eddyP23 But it fails most of test cases.....It is mentioned in the question post. — Jai
– Jai, Commented Jul 20, 2017 at 6:22

atomSmasher · Accepted Answer · 2017-07-20 06:47:04Z

3

Your hours are between 0 and 24 (where 0 and 24 are actually 12:00AM)

function toReadableString(time) {
  if (time < 0)
    time = 0;
  var hrs = ~~(time / 3600 % 24),
    mins = ~~((time % 3600) / 60),
    timeType = (hrs > 11 ? "PM" : "AM");
  if (hrs > 12)
    hrs = hrs - 12;
  if (hrs == 0)
    hrs = 12;
  return hrs + ":" + padZero(mins) + timeType;
}

answered Jul 20, 2017 at 6:47

atomSmasher

1,4632 gold badges16 silver badges37 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Le Duy Khanh Over a year ago

oh yes you are right, I didn't consider 12 and > 12, no one says 14:00 PM, that's how I failed the test.

Feras Al Sous · Accepted Answer · 2017-07-20 06:22:16Z

0

String.prototype.toHHMMSS = function () {
    var sec_num = parseInt(this, 10); // don't forget the second param
    var hours   = Math.floor(sec_num / 3600);
    var minutes = Math.floor((sec_num - (hours * 3600)) / 60);
    var seconds = sec_num - (hours * 3600) - (minutes * 60);

    if (hours   < 10) {hours   = "0"+hours;}
    if (minutes < 10) {minutes = "0"+minutes;}
    if (seconds < 10) {seconds = "0"+seconds;}
    return hours+':'+minutes+':'+seconds;
}

You can use it now like:

alert("5678".toHHMMSS());

answered Jul 20, 2017 at 6:22

Feras Al Sous

1,0811 gold badge12 silver badges26 bronze badges

1 Comment

Jai Over a year ago

what about meridiems?

Collectives™ on Stack Overflow

Javascript integer to time string

2 Answers 2

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related