Pass array of objects to Spring MVC controller using jQuery

Question

I have a POJO as follows, it contains a list of other POJOs:

public class Commit {

    private long revision;
    private Date date;
    private String author;
    private String comment;
    private String akuiteo;
    private List<ChangedPath> changedPathList = new ArrayList<ChangedPath>();

//Getters, Setters and Constructor following
}

My controller expects 3 parameters one of them being an array or a list of Commit:

@RequestMapping(value="/selectedCommits",method=RequestMethod.POST)
@ResponseBody
public List<Commit> getAllDependentCommits(@RequestParam("branch")String branch,
@RequestParam("tag")String tagName,@RequestParam(value="commits[]") Commit[] commits) throws IOException{
    List<String> changedPaths=new ArrayList<String>();
    List<Commit> dependentCommits=UserService.listAllCommits(branch, tagName, commits);
    //UserService.createPatchFromSelectedCommits(branch, tagName, revisions);
    return dependentCommits;
}

I have also tried:List<Commit> commits instead of Commit[ ] commits

I call the controller from a jQuery script using AJAX:

$("#buttonCommit").click(function(e){
console.log(branch);
console.log(tag);
console.log(selectedCommits);
$.ajax({
    url:'selectedCommits?branch='+branch+'&tag='+tag,
    method: 'POST',
    dataType: 'application/json',
    contentType: 'application/json; charset=utf-8',
    data:{
        commits:selectedCommits,
    },
    success:function(data){
        alert('wow smth really happened, here is the response : '+data[1]);
        window.selectedCommits=selectedCommits;
        window.dependentCommits=data.dependentCommits;
        console.log(data.dependentCommits);
    }
})
});

I have also tried: commits:JSON.stringify(selectedCommits)

Every time I get the error:

org.springframework.web.bind.MissingServletRequestParameterException:
Required Commit[] parameter 'commits[]' is not present

I have also tested passing an array of Long representing the revisions and it worked, I can manage using it for my services but it would be nicer to have an array of objects. What am I doing wrong?

Dmitry Senkovich · Accepted Answer · 2017-06-22 10:19:52Z

7

You should use

@RequestBody List<Commit> commits

in your controller instead of

@RequestParam(value="commits[]") Commit[] commits

answered Jun 22, 2017 at 10:19

Dmitry Senkovich

5,9819 gold badges41 silver badges82 bronze badges

Sign up to request clarification or add additional context in comments.

13 Comments

dannemp Over a year ago

If I use a RequestBody will I have to create an object that holds a branch a tag and a commit list so that I can retrieve all 3 parameters?

Dmitry Senkovich Over a year ago

@dannemp no, you don't have to. just replace - and that's all. @RequestParam is used to get query parameter from URL and the @RequestBody is used to map request body - everything is simple:)

Dmitry Senkovich Over a year ago

@dannemp you can move tagName and branch to your url as query parameters. it is not the best practice here. but if you just want to make it work - this is the simplest way

dannemp Over a year ago

Now I get "Content type 'application/x-www-form-urlencoded;charset=UTF-8' not supported" as error

Dmitry Senkovich Over a year ago

@dannemp try to use contentType: "application/json" in your ajax request

|

Angelo Immediata · Accepted Answer · 2017-06-22 09:45:22Z

0

In my project what I did is the following (I'll try to adapt my solution to your code):

$("#buttonCommit").click(function(e){
//Populate the array with selectedCommits values
var myArray = new Array();

$.ajax({
    url:'selectedCommits',
    method: 'POST',
    dataType: 'json',
    data:{
        branch:branch,
        tag:tag,
        commits:myArray,
    },
    success:function(data){
        alert('wow smth really happened, here is the response : '+data[1]);
        window.selectedCommits=selectedCommits;
        window.dependentCommits=data.dependentCommits;
        console.log(data.dependentCommits);
    }
})
});

By doing in this way and without using the JS stringify method all works pretty good

Angelo

answered Jun 22, 2017 at 9:45

Angelo Immediata

6,9526 gold badges39 silver badges72 bronze badges

1 Comment

dannemp Over a year ago

I have tried your solution and it doesn't solve the problem. I log both the selectedCommits and myArray to the console and they are exactly the same.

TanvirChowdhury · Accepted Answer · 2021-02-01 11:24:35Z

JS:

 $.ajax({
        type : "post",
        dataType : 'json', 
        url : 'addAdmin',  
        data : JSON.stringify(selectedCommits)
 })

Controller (note it takes a custom String only). Then it uses Jackson to parse the string manually, because Spring won't do it in this case. (Spring will only auto-parse if you're using @ModelAttribute form binding.)

@PostMapping("/addAdmin")
public boolean addAdmin(@RequestBody String json) throws Exception {

      String decodedJson = java.net.URLDecoder.decode(json, "UTF-8");
      ObjectMapper jacksonObjectMapper = new ObjectMapper(); // This is Jackson
      List<UserRolesGUIBean> userRolesGUIBeans =  jacksonObjectMapper.readValue(
              decodedJson, new TypeReference<List<UserRolesGUIBean>>(){});
      // Now I have my list of beans populated.
}

Collectives™ on Stack Overflow

Pass array of objects to Spring MVC controller using jQuery

3 Answers 3

13 Comments

1 Comment

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

13 Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related