javascript push returning number instead of object [duplicate]

Question

I'm sure this is just some simple silly mistake that I'm missing, but can anyone tell me why 3 is being returned instead of [{ "method": 'popup', "minutes": ''}, {"method": 'email', "minutes": '10'}, {"method": 'popup', "minutes": '20'}];?

I made a jsfiddle so you can see as well: https://jsfiddle.net/qk10arb0/3/

HTML

<p>Click the button to add a new element to the array.</p>

<button onclick="addNewReminder()">Try it</button>

<p id="demo"></p>

Javascript

function addNewReminder(){
      var newReminder = {
        "method": 'popup',
        "minutes": '20'
      };

      var reminders = [{
                "method": 'popup',
                "minutes": ''
              }, {
                  "method": 'email',
                  "minutes": '10'
              }];

    reminders = reminders.push(newReminder);
    document.getElementById("demo").innerHTML = reminders;
}

Thanks!!!

the return value is the new length, this is expected. the original array is mutated so you don't need to return it — aw04
– aw04, Commented May 3, 2017 at 20:17
I do think @kind user's response is clearer as to fix it and the title and approach of this question may make it easier for others experiencing the same issue to find and understand, but I can certainly mark this as a duplicate if you think so. Similar topic, but different explanation in my eyes (hopefully helpful to others that make the silly mistake going forward too) — Rbar
– Rbar, Commented May 3, 2017 at 21:39

kind user · Accepted Answer · 2017-05-03 20:18:21Z

39

Array#push method works in situ, you don't have to assign it to a new variable. It won't return a new array, but will modify the original one and will return it's length. That's why you are getting 3 as the result.

To get the desired result, just call it, without assigning to any variable:

reminders.push(newReminder);

answered May 3, 2017 at 20:18

kind user

42k8 gold badges69 silver badges78 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

vikramvi Over a year ago

Even with above solution, it returns the length of the array and not the final array

kind user Over a year ago

@vikramvi then after pushing new element, return whole array - return reminders;

ÄR Âmmãř Żąîñh Over a year ago

function addNewReminder(){       var newReminder = {         "method": 'popup',         "minutes": '20'       };        var reminders = [{                 "method": 'popup',                 "minutes": ''               }, {                   "method": 'email',                   "minutes": '10'               }];      reminders.push(newReminder);     document.getElementById("demo").innerHTML = reminders; }

Collectives™ on Stack Overflow

javascript push returning number instead of object [duplicate]

1 Answer 1

3 Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Linked

Related