Logic error with array

Question

I am having a logic error with this code. I need to get ten int inputs from the user and then print out any number bigger than 10. The only problem is that if the very last number in the array is bigger than 10 it will not print.

 public class Bigger10
    {
        public static void main(String[] args)
        {
            System.out.println("Please enter 10 integer numbers");

            int[] num = new int[10];
            int count = 0;
            int num1 = StdIn.readInt();

            while(count<9)
            {
                num[count] = num1;
                count++;
                num1 = StdIn.readInt();
            }

            for(int i = 0;i<count;i++)
            {
                if(num[i]>10)
                {
                    System.out.printf("%d ", num[i]);
                }    
            }
        }
    }

thats because you are only checking till 8th index i.e. till 9th element only — warl0ck
– warl0ck, Commented Apr 18, 2017 at 16:44

Makoto · Accepted Answer · 2017-04-18 16:48:06Z

4

Rely on the array to tell you how large it is instead of your constant 9.

The fix is simple: in your loop, iterate over its length instead.

while(count < num.length) {

}

answered Apr 18, 2017 at 16:48

Makoto

107k29 gold badges199 silver badges236 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Ngroenewold Over a year ago

When I do that I get an error: Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: 10. This just means that it's bigger than the array size right?

Leigh · Accepted Answer · 2017-04-18 18:00:17Z

1

        int num1 =0;

        while(count<=9)
        {
            num1 = StdIn.readInt();
            num[count] = num1;
            count++;

        }

count should be <=9, because you need to scan 10 values. If it is <9, then you are only scanning 9 values.

num1 = StdIn.readInt(); should be the first statement in the while loop. If you add it to the end, then you are scanning an extra number. That number is not added to the array because the loop condition becomes false i.e count becomes 10. So the last number is not printed because it is not added to array.

edited Apr 18, 2017 at 18:00

Leigh

28.9k10 gold badges58 silver badges109 bronze badges

answered Apr 18, 2017 at 17:54

Yaaaxi D

112 bronze badges

Comments

user21014068 · Accepted Answer · 2023-02-10 22:30:12Z

0

The issue in the code is with the termination condition of the loop. The loop is only executing 9 times even though you want to read 10 integers from the user. To fix this, you can modify the condition in the while loop as follows:

scss

while(count<10)

Additionally, you should also update the for loop to match the size of the num array, like this:

css

for(int i = 0;i<10;i++

edited Feb 10, 2023 at 22:30

answered Feb 2, 2023 at 19:30

user21014068

365 bronze badges

Collectives™ on Stack Overflow

Logic error with array

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related