AngularJs calling service function from controller

Question

I've got some app in AngularJs, and I've encountered a problem. I need to call a function from service in controller.

my service:

var DataService = ['$http', '$q', '$window', 'alert', function ($http, $q, $window, alert) {
    function print () {
        console.log('smth');
    }
}

my controller:

var Controller = function ($scope, $state, OffersService, commonFunction, dataService, alert, blockUI) {
    function printSmth () {
        dataService.print();
    }
}

function printSmth is called from ng-init in html, and I get exception saying that dataService.print is not a function.

Does anybody know the proper way to do it? I can't change it to .service it must be done this way.

Manikandan Velayutham · Accepted Answer · 2017-04-13 10:00:53Z

1

try like below..

var DataService = ['$http', '$q', '$window', 'alert', function ($http, $q, $window, alert) {
   this.print = function () {
        console.log('smth');
    };
}

or

var DataService = ['$http', '$q', '$window', 'alert', function ($http, $q, $window, alert) {
       function print() {
            console.log('smth');
        };
       return {
        print: print
       };
}

answered Apr 13, 2017 at 10:00

Manikandan Velayutham

2,2281 gold badge17 silver badges22 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Manikandan Velayutham Over a year ago

Welcome @egzaell

Yoan · Accepted Answer · 2017-04-13 10:01:51Z

1

The best way to what you want to accomplish would be something like:

Service:

/* recommended */

// dataservice factory
angular
    .module('app.core')
    .factory('dataservice', dataservice);

dataservice.$inject = ['$http', '$q', '$window', 'alert'];

function dataservice($http, $q, $window, alert) {
    return {
        print : print 
    };

    function print () {
        console.log('smth');
    }
}

Controller:

/* recommended */

// controller calling the dataservice factory
angular
    .module('app.avengers')
    .controller('YourController', YourController);

YourController.$inject = ['$scope', '$state', 'OffersService', 'commonFunction', 'dataservice', 'alert', 'blockUI'];

function YourController($scope, $state, OffersService, commonFunction, dataservice, alert, blockUI) {
    $scope.printSmth = function printSmth() {
           dataService.print();
    };
}

I recommend you start reading some style guides for AngularJS. You will make your life and your development team more productive in the future.

answered Apr 13, 2017 at 10:01

Yoan

2,2171 gold badge14 silver badges21 bronze badges

1 Comment

Rohan Kangale Over a year ago

It is a good example written using some good practices. Please refer this.

Tirthraj Barot · Accepted Answer · 2017-04-13 10:00:11Z

0

var Controller = function ($scope, $state, OffersService, commonFunction, dataService, alert, blockUI) {

Change dataService to DataService

----------------UPDATE--------------------

The function you have defined in controller cannot be accessed in view unless its a $scope function.

So make the print function in your controller to be

$scope.printSmth = function () {
    dataService.print();
}

edited Apr 13, 2017 at 10:00

answered Apr 13, 2017 at 9:23

Tirthraj Barot

2,6792 gold badges19 silver badges33 bronze badges

2 Comments

egzaell Over a year ago

nope, I'm getting the same exception, and about that kind of thinking in that controller I have working access to vars in dataService

Tirthraj Barot Over a year ago

Have a look @egzaell

Collectives™ on Stack Overflow

AngularJs calling service function from controller

3 Answers 3

1 Comment

1 Comment

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

1 Comment

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related