Problems of global variables with Python

Question

I created a small program that shows a window and asks passwords, ids, to check if the user is saved in a database. If password is correct, then it affects True to a boolean named mdp_valide ('password_is_valid' in english) which was False before, and destroys the window of connexion. It's a function that changes that value, so I used a global statement at the top of the function. However, when it closes the window, the value mdp_valide is back to False Here's some code to help you understand

First, the main program that will call the other function:

while 1:
    mdp_valide, utilisateur_en_cours = fenetre_connection(False, None)
    print ('in the main', mdp_valide, utilisateur_en_cours)
    if not mdp_valide:
        sys.exit()
    else :
        lancer_messagerie(utilisateur_en_cours)

Then, the function which is not working:

def fenetre_connection (mdp_val, utilisateur):
    mdp_valide = mdp_val
    utilisateur_en_cours = utilisateur

    root_co = Tk ()

    # .... Lots of stuff

    def verification():
        mdp_co = mot_de_passe.get()
        global mdp_valide
        global utilisateur_en_cours

        if mdp_co == recuperer_donnee_utilisateur (identifiant_utilisateur_co, 'mot_de_passe'): # check if the password is the one of the database

            print ('condition checked')
            mdp_valide = True
            utilisateur_en_cours = identifiant_utilisateur_co
            print ("before destroying : ", mdp_valide, utilisateur_en_cours)
            root_co.destroy()
            print ("after destroying : ", mdp_valide, utilisateur_en_cours)
        else:
            return 1

    Button(Frameboutons_co, text="Valider", font='Cambria', command = verification).pack(side=RIGHT) #Bouton qui verifie la validité du pseudo et du mot de passe


    root_co.mainloop()

    print ('before return : ', mdp_valide)

    return mdp_valide

Test :

before destroying:  True guil23
after destroying :  True guil23
before return :  False None
in the main : False None

The problem is here : the function verification () does change the value of mdp_valide into True, but after returning the value, it's back to False

I don't see global mdp_valide in the function fenetre_connection. That might be your problem. — Robᵩ
– Robᵩ, Commented Apr 10, 2017 at 15:50
Er I removed it, sorry. But it was in the original post. I put it back — Dolly2929
– Dolly2929, Commented Apr 10, 2017 at 16:20
Actually, it was already there, but you might habe been mistaken by the wrong indentation. I corrected it — Dolly2929
– Dolly2929, Commented Apr 10, 2017 at 16:27
Here is a shorter version that illustrate the problem: repl.it/HDdW — njzk2
– njzk2, Commented Apr 10, 2017 at 16:30

njzk2 · Accepted Answer · 2017-04-10 16:35:51Z

2

The problem is that in fenetre_connection, mdp_valide is not global. So it is a local variable. Then in verification, you use global mdp_valide, so that one is a global variable.

When verification finishes, you return the local variable from fenetre_connection.

In python 3 you can use nonlocal: https://docs.python.org/3/reference/simple_stmts.html#the-nonlocal-statement

In python 2, you can declare mdp_valide as global in fenetre_connection so that both variables are in the global scope, and therefore are the same

answered Apr 10, 2017 at 16:35

njzk2

39.4k7 gold badges72 silver badges111 bronze badges

Sign up to request clarification or add additional context in comments.

8 Comments

Dolly2929 Over a year ago

Thanks, it seems to be working again. (I used the global because the nonlocal was a bit over complicated :) ).

Dolly2929 Over a year ago

But still, I don't understand how is that possible. Is not global supposed to take the variable which is somewhere "above" ?

John Y Over a year ago

@Guil23 - global does not mean "somewhere" above, but specifically at the module level.

Dolly2929 Over a year ago

As I had understood, when you have : [Spacename1 : somevariable, [Spacename2]], and you want to access somevariable within Spacename2, using global gives you that access

njzk2 Over a year ago

@Guil23 in your case, you had: a different mdp_valide in global and in fenetre_connection (local) (that would be connexion, btw). In verification, you are using the global one.

|

Collectives™ on Stack Overflow

Problems of global variables with Python

1 Answer 1

8 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

8 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related