string.empty and string.isnullorempty

Question

I have a function like this which checks whether the field is empty or what and if empty then get the setError icon aside the textbox.

      private bool ValidateHost()
      {
        ErrorProvider errorProvider = new ErrorProvider();
        bool isValid = true;

        //If the txtHost is empty, show a message to user            
        if(txtHost.Text == string.Empty)
            {
            errorProvider.SetError(txtHost, "Please enter the host address");
            isValid = false;
            }
        else
            errorProvider.SetError(txtHost, string.Empty);
        return isValid;
      }

but when I tried to use string,isnullorempty then I am not getting the seterror icon.. Can you guys plz tell me what is the proper way of using string.isnullorempty in this case..

How did you use it? It should work perfectly well with if(string.IsNullOrEmpty(txtHost.Text)). — Fredrik Mörk
– Fredrik Mörk, Commented Nov 30, 2010 at 10:59

Jon Skeet · Accepted Answer · 2010-11-30 11:01:24Z

7

My guess is you tried to use it as if it were an instance method, like this:

if (txtHost.Text.IsNullOrEmpty())

It's not an instance method - it's a static method, so you use it like this:

if (string.IsNullOrEmpty(txtHost.Text))

It's not an instance method because otherwise if txtHost.Text was null, the method call would throw a NullReferenceException, which is precisely what we're trying to avoid.

You could write an extension method which could cope with null, but there isn't one in the framework as far as I know.

answered Nov 30, 2010 at 11:01

Jon Skeet

1.5m893 gold badges9.3k silver badges9.3k bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

StuperUser Over a year ago

Plus 1 for the why as a well as the how.

StuartLC · Accepted Answer · 2014-11-24 13:03:03Z

5

string.IsNullorEmpty() is a static method, invoked as follows:

if (string.IsNullOrEmpty(txtHost.Text))
{
    errorProvider.SetError(txtHost, "Please enter the host address"); 
    isValid = false;
}

You can also consider the similar string.IsNullOrWhitespace if spaces, tabs, etc are also invalid.

edited Nov 24, 2014 at 13:03

answered Nov 30, 2010 at 11:00

StuartLC

108k18 gold badges225 silver badges294 bronze badges

Comments

Sachin Shanbhag · Accepted Answer · 2010-11-30 11:01:03Z

0

Change your IF condition to -

if( string.IsNullOrEmpty(txtHost.Text) ) 
{
  ...
}

answered Nov 30, 2010 at 11:01

Sachin Shanbhag

55.7k11 gold badges92 silver badges103 bronze badges

Comments

TomTom · Accepted Answer · 2010-11-30 11:02:45Z

0

Can it be this is not realted to he string test?

ErrorProvider errorProvider = new ErrorProvider();

Hmpf. Seriously. The ErrorProvider should exist on the form. You are just creating one on teh fly (which turns invalid at the end of hthe method) and are not even hooking those up properly in the form.

The ErrorProvider should be put onto the form.

answered Nov 30, 2010 at 11:02

TomTom

62.4k11 gold badges95 silver badges152 bronze badges

Collectives™ on Stack Overflow

string.empty and string.isnullorempty

4 Answers 4

1 Comment

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related