Node + Callback function pass parameters

Question

I am using node with express.

I have two rest api, the difference between the api is only database table only.

Both are post methods,

router.post('test1', findAll);

router.post('test2', findAll);

function findAll(req, res){
//Here test1 api result get from different db table.
//Here test2 api result get from different db table.
How can I sent the db table name in parameters?
//Here have logic in db and return results.
res.send(spec.resp);

}

Note: I need to use same function for both api but the table name only will be change.

cubbuk · Accepted Answer · 2017-02-25 12:23:45Z

1

You can create two function which utilizes common findAll method like following:

function findAllFromTable1(req, res, next){
  return findAll("table1", req, res, next);
}

function findAllFromTable2(req, res, next){
  return findAll("table2", req, res, next);
}

function findAll(tableName, req, res, next){
//db logic
res.send(spec.resp);

}

router.post('test1', findAllFromTable1);

router.post('test2', findAllFromTable2);

But I would suggest you to separate your db logic from route handler, so instead having one function which handles db and send response back, have one function which contains db logic, then in the route handle use that result to send your response. This will make your code easy to understand, easy to test and avoid redundancy.

function findAllFromDB(){
  //db logic 
  return dbResult; // returns a promise since db operations are async.
}

router.post('test1', function(req, res, next){
   findAllFromDB
  .then(function(dbResult){res.send(dbResult)})
  .catch(function(err){  res.status(500).send(err);})
});

edited Feb 25, 2017 at 12:23

answered Feb 25, 2017 at 12:16

cubbuk

7,9284 gold badges39 silver badges64 bronze badges

Sign up to request clarification or add additional context in comments.

7 Comments

RSKMR Over a year ago

if I am wrong means please correct me. need to create function for each db results ?

RSKMR Over a year ago

or please provide one example. I didn;t get "findAllFromDB"

cubbuk Over a year ago

Db logic depends on to which db you are using and which ORM library you are using. But in general yes for each different resource you should generate one helper function.

RSKMR Over a year ago

sorry, Please provide the example.

cubbuk Over a year ago

function findAllUsers(){return db.Users.findAll()} // using sequelize docs.sequelizejs.com/en/v3

|

Collectives™ on Stack Overflow

Node + Callback function pass parameters

1 Answer 1

7 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

7 Comments

Your Answer

Sign up or log in

Post as a guest

Related