Rules in Yii2 models look like this:
[
// checks if "level" is 1, 2 or 3
['level', 'in', 'range' => [1, 2, 3]],
]
Wouldn't it be better if they were objects like this?
[
new RangeRule('level', [1, 2, 3])
]
-
1For performance optimization I guess.Bizley– Bizley2017-02-07 13:56:36 +00:00Commented Feb 7, 2017 at 13:56
-
AFAIK, the performance difference is very minor between arrays and objects.Olle Härstedt– Olle Härstedt2017-02-07 14:01:49 +00:00Commented Feb 7, 2017 at 14:01
-
See stackoverflow.com/questions/2193049/php-objects-vs-arrays and gist.github.com/Thinkscape/1136563 - PHP is getting better at array optimization with every version.Bizley– Bizley2017-02-07 14:06:42 +00:00Commented Feb 7, 2017 at 14:06
-
1Those benchmarks are still old. One for PHP 7 is needed, I think.Olle Härstedt– Olle Härstedt2017-02-07 14:15:36 +00:00Commented Feb 7, 2017 at 14:15
-
1Loading the class file is only done once. I think the arrays make the rules much harder to read, but if it's possible to use the objects instead if you want to, then no problem.Olle Härstedt– Olle Härstedt2017-02-08 09:09:01 +00:00Commented Feb 8, 2017 at 9:09
|
Show 6 more comments
1 Answer
You can use validator objects like this:
use yii\validators\Validator;
use yii\validators\NumberValidator;
use yii\validators\StringValidator;
class TestModel extends \yii\base\Model
{
public $firstProperty;
public $secondProperty;
public function rules()
{
return [
new NumberValidator(['attributes' => ['firstProperty'], 'integerOnly' => true, 'min' => 0, 'max' => 100]),
new StringValidator(['attributes' => ['secondProperty'], 'max' => 5]),
];
}
}
Moreover, you can decorate these objects as you want (using additional classes and methods):
class TestModel extends \yii\base\Model
{
public $firstProperty;
public $secondProperty;
public function rules()
{
// Prepare Int validator
$validatorInt = new NumberValidator();
$validatorInt->integerOnly = true;
$validatorInt->min = 0;
$validatorInt->max = 100;
// Prepare String validator
$validatorString = new StringValidator();
$validatorString->max = 5;
// Make rules
return [
static::_makeRule(['firstProperty'], $validatorInt),
static::_makeRule(['secondProperty'], $validatorString),
];
}
protected function _makeRule($attrName, Validator $validatorObj)
{
$validatorObj = clone $validatorObj;
$validatorObj->attributes = (array)$attrName;
$validatorObj->init(); // Initializes validator and normalizes values
return $validatorObj;
}
}
Comments
