JavaScript in HTML: Getting undefined input value?

Question

For some reason, when I enter a value in the following script, the value of ISBN is always undefined. I'm not sure why this is the case. I have set the button to run the function onclick as well...

HTML:

<form id="frm1">
    Book ISBN: <input type="text" name="fname"><br><br>
    <input type="button" onclick="myFunction()" value=行きましょう！>
</form>

JavaScript

function myFunction() {
    var isbn = document.getElementById("frm1").submit(); // Replace with ISBN / EISBN / ASIN of the book
    alert("Starting!");
    alert(isbn);

    var api_key = "cf6f5fe91531a855495d77fc06dd9ada6f1fa1f7"; //Replace with the developer key (Submit the form to get a key)

    //Optional Settings
    var smiley = 'true'; // Change to false if do not want to show smiley with each review
    var width = 700;     // Width of the reviews iframe
    var height = 400;    // Height of the reviews iframe
    var wf = document.createElement('script');
    var host = "idreambooks.com";  

    wf.src = ('https:' == document.location.protocol ? 'https' : 'http') +
              '://' + host + '/reviews_widget.js?api_key=' + api_key + '&isbn=' + isbn +
              '&smiley=' + smiley + '&width=' + width + '&height=' + height;
    wf.type = 'text/javascript';
    wf.async = 'true';

    var s = document.getElementsByTagName('script')[0];
    s.parentNode.insertBefore(wf, s);
}

Is there anything I'm missing about how to get input values?

submit() method doesn't have return value, that's why you're getting undefined — Jovica Šuša
– Jovica Šuša, Commented Feb 1, 2017 at 20:26

Tyler Biscoe · Accepted Answer · 2017-02-01 20:54:29Z

6

var isbn = document.getElementById('someIdYouAssignTheInput').value;

As mentioned above, submit doesn't return anything, which is why the value is undefined. You want to get the value of the input element. The best way to do that is to assign it an id, then use the code I included above.

Good luck!

edited Feb 1, 2017 at 20:54

answered Feb 1, 2017 at 20:24

Tyler Biscoe

2,4423 gold badges23 silver badges34 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Loveen Dyall · Accepted Answer · 2017-02-01 20:26:04Z

5

try

 var isbn = document.getElementsByName("fname")[0].value;

to retrieve the input text box's value.

answered Feb 1, 2017 at 20:26

Loveen Dyall

8342 gold badges9 silver badges21 bronze badges

Collectives™ on Stack Overflow

JavaScript in HTML: Getting undefined input value?

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related