Change JS function to jQuery

Question

How can I change this code to take advantage of jQuery?

function download(elm) {
    var iframe = document.createElement("iframe");
    var param = elm.innerHTML; //$get("filedownload").innerHTML;        
    //iframe.src = "GenerateFile.aspx?filename=386c1a94-fa5a-4cfd-b0ae-40995062f70b&ctype=application/octet-stream&ori=18e73bace0ce42119dbbda2d9fe06402.xls";// + param;
    iframe.src = "GenerateFile.aspx?" + param;

    iframe.style.display = "none";

    document.body.appendChild(iframe);
}

Nick Craver · Accepted Answer · 2010-11-15 10:36:40Z

10

It would look like this:

function download(elm) {
  $("<iframe />", { src: "GenerateFile.aspx?" + elm.innerHTML })
    .appendTo("body").hide();
}

This is the jQuery 1.4+ $(html, props) syntax, for older versions it would look like this:

function download(elm) {
  $("<iframe />").attr("src","GenerateFile.aspx?" + elm.innerHTML)
    .appendTo("body").hide();
}

Past the creation .appendTo() appends the element you created to the selector passed in ("body"), and .hide() covers the display: none; styling.

answered Nov 15, 2010 at 10:36

Nick Craver

631k138 gold badges1.3k silver badges1.2k bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

RPM1984 Over a year ago

don't forget iframe.style.display = 'none';

Klaster_1 Нет войне Over a year ago

Thanks, I didn't know about $(html, props) syntax before. That would be pretty useful.

RPM1984 Over a year ago

This is why i love jQuery - 7 lines of ugly javascript turned into one chained line of sexiness. :)

Collectives™ on Stack Overflow

Change JS function to jQuery

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related