Adding integer elements to list JAVA

Question

I am trying to separate digits from an Integer and then put them into an array.

All elements, except for the first, are printing as 0. Could someone explain why this is it happening?

public class Doom{
    public static void main(String[] args){
        int number = 1234;
        int[] list = new int[5];
        while (number > 0) {

            int x = 0;
            int fork = (number%10);
            System.out.println(fork);
            list[x] = fork;
            x++;
            number = number / 10;
        }
        for (int x : list){
            System.out.println(x);
        }

    }
}

Your problem, aside from the best variable names, is that int x = 0; is inside your while loop. It keeps getting reset to 0 on every iteration. — Welbog
– Welbog, Commented Jan 23, 2017 at 21:14

Jonathan Gilbert · Accepted Answer · 2017-01-23 21:15:07Z

2

The problem is that you are declaring x inside the loop, so it gets reset to 0 each time. You want to move the int x = 0; line to be above the while (number > 0) { line, outside of the loop. Then it will be initialized to 0 only once, and each pass through the loop can assign it a new value with the x++ line.

answered Jan 23, 2017 at 21:15

Jonathan Gilbert

3,91026 silver badges32 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Makoto · Accepted Answer · 2017-01-23 21:15:49Z

1

You keep redeclaring x in your loop, causing only the first index to have meaningful data. Move it to the outside of your loop.

answered Jan 23, 2017 at 21:15

Makoto

107k29 gold badges199 silver badges236 bronze badges

Comments

VHS · Accepted Answer · 2017-01-23 21:47:13Z

0

There are quite a few errors in your program. Biggest one is that you are inializing x to 0 and then incrementing it by 1 within the while loop. It will keep storing your digits at the same location (0th place). Compare the following snippet and try to learn your mistakes:

public class Doom{
    public static void main(String[] args){
        int number = 1234;
        int[] list = new int[String.valueOf(number).length()];
        int x = 0;
        while (number > 0) {        
            int fork = (number%10);
            System.out.println(fork);
            list[x] = fork;
            x++;
            number = number / 10;
        }
        for (int y : list){
            System.out.println(y);
        }

    }
}

edited Jan 23, 2017 at 21:47

answered Jan 23, 2017 at 21:25

VHS

10.2k3 gold badges25 silver badges48 bronze badges

4 Comments

VHS Over a year ago

It can be initialized to 0 too. But then you need to do list[x] = fork. Just updated my answer accordingly.

KillerHawx Over a year ago

How can i use the length of the integer directly? i mean like something that would do int[] list = new int[number.length] , without errors ofcourse

VHS Over a year ago

@KillerHawx, you can get the length (number of digits) of 'number' by this way: int length = String.valueOf(number).length();

VHS Over a year ago

@KillerHawx, I just edited the answer to reflect that.

Miki P · Accepted Answer · 2017-01-23 21:16:56Z

0

You are reinitializing x to 0 every time. Declare it outside of the while loop.

answered Jan 23, 2017 at 21:16

Miki P

6521 gold badge9 silver badges22 bronze badges

Collectives™ on Stack Overflow

Adding integer elements to list JAVA

4 Answers 4

Comments

Comments

4 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

4 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related