Style PHP variable in JavaScript

Question

<?php    
...
$name = trim($_POST["username"]);
...
echo '<script type="text/javascript">document.getElementById("message").innerHTML=
"<span style='color:red;'>'.$name.'</span> <br>login now";</script>';

?>

Why the style isn't working? When I erase the style and span the code is working fine.

"isn't working" meaning it prints(echo) nothing, so my guess is that this code is not valid... — Comrade57
– Comrade57, Commented Jan 9, 2017 at 21:26

Jacob G · Accepted Answer · 2017-01-09 21:24:31Z

2

Your need to escape the quotes around 'color:red;', that's invalid:

echo '<script type="text/javascript">document.getElementById("message").innerHTML=
"<span style=\'color:red;\'>'.$name.'</span> <br>login now";</script>'

answered Jan 9, 2017 at 21:24

Jacob G

14.2k4 gold badges50 silver badges67 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Comrade57 Over a year ago

Thank you so much!

Jacob G Over a year ago

No problem, glad I could help :)

Mohammad · Accepted Answer · 2017-01-09 21:29:17Z

0

Your need to escape style=\'color:red;\'

<?php
echo '<div id="message"></div>
            <script type="text/javascript">document.getElementById("message").innerHTML=
                    "<span style=\'color:red;\'>'.$name.'</span> <br>login now";</script>';
?>

edited Jan 9, 2017 at 21:29

answered Jan 9, 2017 at 21:27

Mohammad

4973 silver badges17 bronze badges

3 Comments

Jacob G Over a year ago

How's this any different than my answer?

Mohammad Over a year ago

oh , You sent this answer .

Jacob G Over a year ago

yeah, I guess we both had the same idea :)

Collectives™ on Stack Overflow

Style PHP variable in JavaScript

2 Answers 2

2 Comments

3 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related