Python switch the output based on input

Question

Can we write the following code in one line, when a function switch the current player another one?

    def switch_user(self,current):
       if self.current == 'Player-1':
              self.current = 'Player-2'
      elif self.current == 'Player-2':
           self.current = 'Player-1'
    return

@e0k While that would work, it sounds like this question isn't really asking about equivalents for a switch statement - the use of the word "switch" is coincidental. It seems to be asking how to concisely toggle between two values. — David Z
– David Z, Commented Dec 17, 2016 at 7:12
@DavidZ Good point. The code looks similar to a switch statement because it is making multiple comparisons against the same value. That must have distracted me. The word "switch" in the question only refers to switching players. — e0k
– e0k, Commented Dec 17, 2016 at 7:22

Amber · Accepted Answer · 2016-12-17 06:56:06Z

2

self.current = 'Player-2' if self.current == 'Player-1' else 'Player-1'

answered Dec 17, 2016 at 6:56

Amber

531k89 gold badges643 silver badges558 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Mohammad Yusuf Over a year ago

shouldn't that be current == 'Player-1' instead of self.current == 'Player-1'?

e0k Over a year ago

@MohammadYusufGhazi current would make more sense (otherwise you're not using the argument), but then the example in the question is also incorrect.

EveryProblemHasSolution Over a year ago

I am using self because 'current' is a global variable, with self.current it becomes local.

Nath · Accepted Answer · 2016-12-17 12:03:18Z

1

To make things expandable to multiple players I'd use cycle from the itertools standard library https://docs.python.org/2/library/itertools.html#itertools.cycle

from itertools import cycle      

players_cycle = cycle(['Player-1', 'Player-2'])

current = players_cycle()

This way you are able add a third player or make the player objects more complex over time Without having to redo the switch function.

edited Dec 17, 2016 at 12:03

answered Dec 17, 2016 at 10:59

Nath

1,0039 silver badges21 bronze badges

Collectives™ on Stack Overflow

Python switch the output based on input

2 Answers 2

3 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related