How to remove Object from array using mongoose

Question

I'm trying to remove an object from an array in a document using mongoose.

The Schema is the following:

var diveSchema = new Schema({
//irrelevant fields
    divers: [{
        user: { type: Schema.Types.ObjectId, ref: 'User', required: true },
        meetingLocation: { type: String, enum: ['carpool', 'onSite'], required: true },
        dives: Number,
        exercise: { type: Schema.Types.ObjectId, ref: 'Exercise' },
    }]
});

a possible entry can be

{
    //irrelevant fields
    "divers": [
        {
            "_id": "012345678",
            "user": "123456789",
            "meetingLocation": "carpool",
            "exercise": "34567890",
        },
        {
            "_id": "012345679",
            "user": "123456780",
            "meetingLocation": "onSite",
            "exercise": "34567890",
        }
    ]
}

Say I want to remove the entry where user is 123456789 (note I do not know the _id at this point).

How do I do this correctly?

I tried the following:

        var diveId = "myDiveId";
        var userIdToRemove = "123456789"
        Dive.findOne({ _id: diveId }).then(function(dive) {
            dive.divers.pull({ user: userIdToRemove });
            dive.save().then(function(dive) {
                //do something smart
            });
        });

This yieled no change in the document.

I also tried

Dive.update({ _id: diveId }, { "$pull": { "divers": { "diver._id": new ObjectId(userIdToRemove) } } }, { safe: true }, function(err, obj) {
    //do something smart
});

With this I got as result that the entire divers array was emptied for the given dive.

Rahul Kumar · Accepted Answer · 2016-11-14 12:35:23Z

39

What about this?

Dive.update({ _id: diveId }, { "$pull": { "divers": { "user": userIdToRemove } }}, { safe: true, multi:true }, function(err, obj) {
    //do something smart
});

answered Nov 14, 2016 at 12:35

Rahul Kumar

2,8411 gold badge24 silver badges31 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Sonaryr Over a year ago

this seems to work! thanks, but can you also explain what I did wrong, because I did try to just use user before, but I didn't add the multi part

chridam Over a year ago

How is this option { safe: true, multi:true } helpful when you have an update operation that queries a single document { _id: diveId }?

Rahul Kumar Over a year ago

@chridam , you are right, for single document and $pull it would be overkill to use multi:true , but to be honest, I have come across some drivers which stops executing as soon as it does just one operation (not document) if you don't provide multi as true. For example if you call $set inside an array, the driver just sets the first element of array for some driver. That's the reason I use it. You can avoid it.

Rahul Kumar Over a year ago

@Sonaryr if you did try this same query, maybe the reason it didn't work is mentioned in my previous comment, it all basically boils down how your driver has implemented the operations.

Al Imran Hossain · Accepted Answer · 2021-10-11 05:10:31Z

6

I solve this problem using this code-

 await Album.findOneAndUpdate(
    { _id: albumId },
    { $pull: { images: { _id: imageId } } },
    { safe: true, multi: false }
  );
  return res.status(200).json({ message: "Album Deleted Successfully" });

answered Oct 11, 2021 at 5:10

Al Imran Hossain

2053 silver badges14 bronze badges

1 Comment

Minhaz Over a year ago

This is awesome. It's worked for me.

pankaj007 · Accepted Answer · 2016-11-14 12:42:58Z

0

Try this

Dive.update({ _id: diveId },{"$pull": { "drivers": {"user": "123456789"}}})

answered Nov 14, 2016 at 12:42

pankaj007

957 bronze badges

1 Comment

Hola Soy Edu Feliz Navidad Over a year ago

Same answer as above.

General Grievance · Accepted Answer · 2021-09-16 12:25:20Z

0

Try this async code

var diveId = "myDiveId";
var userIdToRemove = "123456789"
const dive=await Dive.findOne({ _id: diveId })
await dive.divers.pull({ user: userIdToRemove });
await dive.save();

edited Sep 16, 2021 at 12:25

General Grievance

5,12039 gold badges39 silver badges60 bronze badges

answered Sep 16, 2021 at 4:59

Tazim Karim Madre

497 bronze badges

1 Comment

user14518353 Over a year ago

Welcome to Stack Overflow! Your answer might be more helpful to others if you explained how/why it works, and/or why this solution is better than the existing answers that have already been here for a while :)

Tyler2P · Accepted Answer · 2022-12-18 10:59:45Z

0

Use this with try/catch:

await Group.updateOne(
  { _id: groupId },
  { $pull: { members: {id: memberId }}}
);

edited Dec 18, 2022 at 10:59

Tyler2P

2,37030 gold badges26 silver badges34 bronze badges

answered Dec 18, 2022 at 8:59

ZAFAR HUSSAIN

2012 silver badges4 bronze badges

Collectives™ on Stack Overflow

How to remove Object from array using mongoose

5 Answers 5

4 Comments

1 Comment

1 Comment

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

4 Comments

1 Comment

1 Comment

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest