Want to pass php variable as argument in javascript function?

Question

i want to pass my php variable in one javascript function.
i know it seems simple but i don't know where am i missing something?

    <?php
        while($gg=mysql_fetch_array($lg))
        {
    ?>
        <td id="add_td">
        <?php
        $id = $gg['p_id'];
        echo "<a onclick=cnf('Are you sure you want to delete that?',$id)>"; ?>Delete</a>
        </td>
<?php
        }
?>

and in my javascript function

function cnf(msg,id)
{

     cnf = confirm(msg);
     if(cnf) { 
            parent.location.href = 'p_update.php?d=' + id;          
     }
}

so i need to know on which id that user had clicked so that i will only delete that id from database.
if i try this thing then it showing error on "cnf" function and its saying like "unterminated string literal"?

I can see errors which validator.w3.org will pick up (and when you have code generated by other code which breaks, you'll find it much easier to get an answer if you look at the generated code and try to narrow the question down to "Why doesn't this JavaScript work?" or "Why doesn't this PHP output this JavaScript?" instead of "Why doesn't the JavaScript generated by this PHP work?") — Quentin
– Quentin, Commented Oct 29, 2010 at 8:47

Eldar · Accepted Answer · 2010-10-29 08:51:40Z

4

if $id is not numeric you should write 

<?php
        while($gg=mysql_fetch_array($lg))
        {
    ?>
        <td id="add_td">
        <?php
        $id = $gg['p_id'];
        echo "<a onclick=cnf('Are you sure you want to delete that?','".$id."')>"; ?>Delete</a>
        </td>
<?php
        }
?>

edited Oct 29, 2010 at 8:51

answered Oct 29, 2010 at 8:45

Eldar

8729 silver badges22 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Nitz Over a year ago

in this also cnf was showing error called unterminated string literal but i just put one thing in it...... echo "<a onclick=\"cnf('Are you sure you want to delete that?','".$id."')\">Delete</a>";

Stephen Rauch · Accepted Answer · 2018-06-17 03:16:58Z

2

Use quotes around php variable '$id'.

echo "<a onclick=cnf('Are you sure you want to delete that?','$id')>";

Another example, $p is some php variable,

echo "<input type=button value='update' onclick=myfunc('$p')>"

edited Jun 17, 2018 at 3:16

Stephen Rauch♦

50.1k32 gold badges118 silver badges143 bronze badges

answered Jun 17, 2018 at 2:55

Lagrange

1052 silver badges8 bronze badges

Comments

Chinmayee G · Accepted Answer · 2010-10-29 08:34:32Z

1

Check your syntax

<?php
    while($gg=mysql_fetch_array($lg))
    {
?>
        <td id="add_td">
        <?php
        $id = $gg['p_id'];
        ?>
        <a onclick="cnf('Are you sure you want to delete that?',<?=$id?>);">Delete</a>
        </td>
<?php
     }
?>

answered Oct 29, 2010 at 8:34

Chinmayee G

8,1172 gold badges34 silver badges41 bronze badges

4 Comments

mplungjan Over a year ago

Yeah, it should be '<?php echo $id; ?>' it is php not asp

Chinmayee G Over a year ago

<?=$id?> is also valid php markup. codeigniter.com/user_guide/general/alternative_php.html for alternative echo markup in php

Coquevas Over a year ago

Short tags shouldn't be used because support is not guaranteed on shared servers and it's being removed completely next major version: stackoverflow.com/questions/200640/…

mplungjan Over a year ago

Too bad, I definitely prefer <?= id ?> to the <?php....;?> one - never knew it existed

mplungjan · Accepted Answer · 2010-10-29 08:46:35Z

1

I would do something like this instead. HREF is mandatory if you want the "hand" pointer A unique ID is also mandatory on tags and you need to quote the ID if you pass it in the function instead of what I suggest and give the link the id

function cnf(link,id) {
  if (confirm("Are you sure you want to delete "+id) {
    link.href = "p_update.php?d=" + id;          
    return true;
  }
  return false;
}

<?php
  while($gg=mysql_fetch_array($lg)) { 
    $id = $gg['p_id'];
?>
  <td id="add_td<?php echo $id; ?>"><a target="_parent" href="#" id="<?php echo $id; ?>" onclick="return cnf(this)">Delete</a></td>
<?php } ?>

answered Oct 29, 2010 at 8:46

mplungjan

180k29 gold badges183 silver badges246 bronze badges

Comments

Alex · Accepted Answer · 2011-10-05 14:54:18Z

1

foreach($mas as $k=>$v) {
  //echo $k.' = '.$v.'<br>';
  echo("

    <input type=\"button\" id=\"delete_id".$k."\" value=\"Blablabla\" onclick=\"alert('".$v."');\"/>

  ");
}

If I put there $k (index) it works but if string (value is string), I get an error

unterminated string literal

In HTML tags this works but not as the function argument!

answered Oct 5, 2011 at 14:54

Alex

111 bronze badge

2 Comments

Alex Over a year ago

Offcourse I can make an invisible <div> tag with some id and put in there $v as the value, and get it using getElementById. But maybe there is some right syntax to put a php variable into JS function??

Serge Belov Over a year ago

This is not an answer to the original question and might be worthwhile having as a separate question. Please have a look at this page.

Kel · Accepted Answer · 2010-10-29 08:34:05Z

0

If $id is a string literal, you should put it into quotes when you are passing it as a parameter to cnf() function in <a ... > tag:

echo "<a onclick=cnf('Are you sure you want to delete that?', '$id')>";

answered Oct 29, 2010 at 8:34

Kel

7,8103 gold badges32 silver badges39 bronze badges

2 Comments

Eldar Over a year ago

because in output it place string $id, it wont parse variable in sigle quotes

Gordon Over a year ago

@eldar the echo statement is in double quotes.

Collectives™ on Stack Overflow

Want to pass php variable as argument in javascript function?

6 Answers 6

1 Comment

Comments

4 Comments

Comments

2 Comments

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

1 Comment

Comments

4 Comments

Comments

2 Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related