Parsing to Check if NAN Javascript

Question

I have an onclick even set up to take the value of an input and alert if the value is a number. If the value of the input is blank, I am trying to alert it to say "No Number," however, it seems that even if my input it empty the function returns a statement saying the the "empty" value is indeed a number.

I have set variable up to parse the value of the input right away, but is this why my code is always returning "Is a number," because it's automatically set to be one when it collects the variable?

Code:

HTML:

<input type="text" id="numberTest" />

<button id="button">Click Me</button>

JS:

var button = document.getElementById("button");

button.onclick = function()
{
var numberTest = parseInt(document.getElementById("numberTest").value);

if(numberTest == NaN || "" || null)
{
    alert("No Number");
}
else
{
    alert("This is a number!");
}
};

Possible duplicate of Is there any function like IsNumeric in javascript to validate numbers — Liam
– Liam, Commented Aug 24, 2016 at 13:08
The duplicate of that is probably better actually Validate decimal numbers in JavaScript - IsNumeric() — Liam
– Liam, Commented Aug 24, 2016 at 13:09

Scott · Accepted Answer · 2016-08-24 13:08:29Z

7

Checking if == NaN will always return false. The proper way to do this is with Number.isNaN():

var button = document.getElementById("button");

button.onclick = function() {
    var numberTest = parseInt(document.getElementById("numberTest").value);
    if (Number.isNaN(numberTest) || numberTest == "" || numberTest === null) {
        alert("No Number");
    }
    else {
        alert("This is a number!");
    }
};

You also had some issues with your logic in the if - each clause is a separate expression, and therefore needs to check against numberTest every time.

answered Aug 24, 2016 at 13:08

Scott

5,3695 gold badges49 silver badges74 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Alan Jurczak · Accepted Answer · 2021-01-18 10:38:12Z

3

Try using isNaN() method:

isNaN(numberTest)

instead of

numberTest == NaN

According to NaN documentation, NaN is never equal NaN, so NaN == NaN or NaN === NaN will always return false...

BTW, you should change that:

if(numberTest == NaN || "" || null)

to this:

if(isNaN(numberTest) || numberTest == "" || numberTest == null)

so you always compare your variable to a value.

edited Jan 18, 2021 at 10:38

answered Aug 24, 2016 at 13:07

Alan Jurczak

4785 silver badges14 bronze badges

Comments

Monicalh · Accepted Answer · 2018-03-06 08:19:45Z

2

This is another way to know if value is number or not

function IsANumber(numberToValidate) {
   return $.isNumeric(numberToValidate.replace(",", "").replace(".", ""));
} 
$("[id^=YourIDButton]").click(function(){
    if(IsANumber($(this).val())){
       alert("This is a number!");
    }else{
       alert("No number");
    }
}

answered Mar 6, 2018 at 8:19

Monicalh

1011 silver badge5 bronze badges

Collectives™ on Stack Overflow

Parsing to Check if NAN Javascript

3 Answers 3

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related