AngularJS using ng-repeat array key changes with filter

Question

I have an array of zipcodes:

var zipcodes = [ 
{ "Zipcode":"00501", "State":"NY", "City":"Holtsville" }, 
{ "Zipcode":"90210", "State":"CA", "City":"Beverly Hills" },
{ "Zipcode":"00544", "State":"NY", "City":"Holtsville" }
];

I am listing them in a table as:

<input type="text" ng-model="query" placeholder="Search..."><br>
<table>
<tr ng-repeat="(key, zipcode_data) in zipcodes | filter: query" ng-click="edit_zip(key)"> 
<td>{{ zipcode_data.Zipcode }}</td>
<td>{{ zipcode_data.City }}</td>
</tr>
</table>

Clicking the row opens an edit dialog and this works fine... however, if I filter the data, the key changes. This brings up the wrong record (key) from the original array in the edit dialog (if the filtered list happens to reorder.)

For example, if I filter on city 'Holtsville', there will be two rows shown, click on the second record sends key 1, however the zipcodes array key 1 is for 90210.

$scope.edit_zip = function(index) {
 $scope.index = index;
 var modal = ngDialog.open({
  scope: $scope,
  template: 'zip_edit.html'
 });
}

Is there a way to preserve the original array index in the ng-repeat so that it properly binds to the correct array element?

kukkuz · Accepted Answer · 2016-07-29 16:40:02Z

1

Always use zipcode_data and never index as later on when you add orderBy or filter you will run into issues as index is not preserved:

<input type="text" ng-model="query" placeholder="Search..."><br>
<table>
<tr ng-repeat="zipcode_data in zipcodes | filter: query" ng-click="edit_zip(zipcode_data)"> 
<td>{{ zipcode_data.Zipcode }}</td>
<td>{{ zipcode_data.City }}</td>
</tr>
</table>

and your js like this:

$scope.edit_zip = function(item) {
 $scope.item = item;
 var modal = ngDialog.open({
  scope: $scope,
  template: 'zip_edit.html'
 });
}

NOTE: You shouldn't try for a way to preserve the original array index in the ng-repeat- if you think about it, you won't be able to make it work with filter.

edited Jul 29, 2016 at 16:40

answered Jul 29, 2016 at 15:53

kukkuz

42.5k6 gold badges65 silver badges103 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Ted Scheckler Over a year ago

Thank you... I hadn't thought of just passing zipcode_data, and that works exactly how I need it to.

Collectives™ on Stack Overflow

AngularJS using ng-repeat array key changes with filter

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related