Error while adding multiple Views to a LinearLayout programatically

Question

I was trying to add a View multiple times by using a for loop, but I was getting an error

Caused by: java.lang.IllegalStateException: The specified child already has a parent. You must call removeView() on the child's parent first.

My XML file

<?xml version="1.0" encoding="utf-8"?>
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:app="http://schemas.android.com/apk/res-auto"
    xmlns:tools="http://schemas.android.com/tools"
    android:layout_width="match_parent"
    android:layout_height="match_parent"
    android:orientation="vertical"
    android:paddingBottom="@dimen/activity_vertical_margin"
    android:paddingLeft="@dimen/activity_horizontal_margin"
    android:paddingRight="@dimen/activity_horizontal_margin"
    android:paddingTop="@dimen/activity_vertical_margin"
    app:layout_behavior="@string/appbar_scrolling_view_behavior"
    tools:showIn="@layout/activity_display_list"
    android:id="@+id/root_layout">
</LinearLayout>

My class file

ViewGroup ll = (ViewGroup) findViewById(R.id.root_layout);
TextView tv = (TextView) new TextView(this);
tv.setText("helloworld");
tv.setLayoutParams(new LinearLayout.LayoutParams(LinearLayout.LayoutParams.MATCH_PARENT,LinearLayout.LayoutParams.MATCH_PARENT));

//adding views in loop
for(int i=0;i<=5;i++)
{
    ll.addView(tv);
}

Where am I going wrong?

You're trying to add the same TextView five times. Move everything except the findViewById() line to inside your loop. And you probably don't want MATCH_PARENT params for both dimensions. — Mike M.
– Mike M., Commented Jun 24, 2016 at 7:34
Why is it so? why to create the object 5 times when we can create it once and use it 5 times? — Mani Sankar
– Mani Sankar, Commented Jun 24, 2016 at 7:39
That doesn't really make any sense. If you want five TextViews, you need to create five of them. — Mike M.
– Mike M., Commented Jun 24, 2016 at 7:40

earthw0rmjim · Accepted Answer · 2016-06-24 07:48:27Z

3

You cannot add the same View multiple times to the same layout.

The following should work:

ViewGroup ll = (ViewGroup) findViewById(R.id.root_layout);

for(int i=0; i<=5; i++)
{
    TextView tv = (TextView) new TextView(this);
    tv.setText("helloworld");
    tv.setLayoutParams(new LinearLayout.LayoutParams(LinearLayout.LayoutParams.MATCH_PARENT, LinearLayout.LayoutParams.MATCH_PARENT));
    ll.addView(tv);
}

Also, setting either the height or the width (maybe both, depending on the orientation of your LinearLayout) of the TextView to WRAP_CONTENT might make more sense.

edited Jun 24, 2016 at 7:48

answered Jun 24, 2016 at 7:36

earthw0rmjim

19.5k9 gold badges54 silver badges65 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Neo · Accepted Answer · 2016-06-24 07:40:49Z

0

You should use LinearLayout, and need to create textview and params everytime, because you can't add single view multiple times -

    LinearLayout ll = (LinearLayout) findViewById(R.id.root_layout);

          //adding views in loop
          for(int i=0;i<=5;i++)
          {
             TextView tv = (TextView) new TextView(this);
             tv.setText("helloworld");
             ll.addView(tv, new LinearLayout.LayoutParams(LinearLayout.LayoutParams.MATCH_PARENT,LinearLayout.LayoutParams.MATCH_PARENT));
          }

Hope it will help :)

answered Jun 24, 2016 at 7:40

Neo

3,5941 gold badge28 silver badges31 bronze badges

Comments

ankit_agarwal · Accepted Answer · 2016-06-24 07:45:31Z

0

Try this:

for(int i=0;i<=5;i++){
    ViewGroup ll = (ViewGroup) findViewById(R.id.root_layout);
    TextView tv = (TextView) new TextView(this);
    tv.setText("helloworld");
    tv.setLayoutParams(new        LinearLayout.LayoutParams(LinearLayout.LayoutParams.MATCH_PARENT,LinearLayout.LayoutParams.MATCH_PARENT));

    ll.addView(tv);

}

answered Jun 24, 2016 at 7:45

ankit_agarwal

11 bronze badge

1 Comment

user3378165 Over a year ago

What are you asking here? Please explain.

Kush · Accepted Answer · 2016-06-24 07:41:34Z

-1

Try it, may it help..

 //adding views in loop
    for(int i=0;i<=5;i++)
    {
    if(tv.getParent()!=null)
    {
        ((ViewGroup)tv.getParent()).removeView(tv);
    }
    ll.addView(tv); 
}

thanks..

answered Jun 24, 2016 at 7:41

Kush

1,09212 silver badges16 bronze badges

Collectives™ on Stack Overflow

Error while adding multiple Views to a LinearLayout programatically

4 Answers 4

Comments

Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related