Simple JavaScript quiz array issue

Question

I'm a programming newbie and am working through a quiz from Treehouse. I don't want to just look at the solution but I'm stuck. I want to store each correct question in a new array and the same for each wrong question, then print them out. My code keeps track of each right and wrong question, but it's only saving one question to each new array, even if more than one is correct or incorrect. I'm sure it's something simple, but what am I doing wrong?

var questions = [
  ['How many states are in the United States?', '50'],
  ['How many legs does a spider have?', '8'],
  ['How many continents are there?', '7']
];

function quiz(quizQuestions) {
  var counter = 0;
  
  for (var i = 0; i < questions.length; i++) {
    var answer = prompt(questions[i][0]);
    
    if (answer === questions[i][1]) {
      var correctAnswers = [questions[i][0]];
      counter += 1;
    } else {
      var wrongAnswers = [questions[i][0]];
    }
  }

  print('<h2>You got these questions right</h2>');
  print(correctAnswers);
  print('<h2>You got these questions wrong</h2>');
  print(wrongAnswers);
  
  var printQuestionsRight = '<h3>You got ' + counter + ' questions right</h3>';
  print(printQuestionsRight);
}

function print(message) {
  document.write(message);
}

quiz(questions);

Keep it in array than variable

Rayon
– Rayon

2016-05-27 10:33:54 +00:00
Commented May 27, 2016 at 10:33 — Rayon
– Rayon, Commented May 27, 2016 at 10:33

Rayon · Accepted Answer · 2016-05-27 10:36:07Z

3

Use array to hold the questions than variable

The join() method joins all elements of an array into a string.

var questions = [
  ['How many states are in the United States?', '50'],
  ['How many legs does a spider have?', '8'],
  ['How many continents are there?', '7']
];
var correctAnswers = [];
var wrongAnswers = [];

function quiz(quizQuestions) {
  var counter = 0;
  for (var i = 0; i < questions.length; i++) {
    var answer = prompt(questions[i][0]);
    if (answer === questions[i][1]) {
      correctAnswers.push([questions[i][0]]);
      counter += 1;
    } else {
      wrongAnswers.push([questions[i][0]]);
    }
  }
  print('<h2>You got these questions right</h2>');
  print(correctAnswers.join('<br>'));
  print('<h2>You got these questions wrong</h2>');
  print(wrongAnswers.join('<br>'));
  var printQuestionsRight = '<h3>You got ' + counter + ' questions right</h3>';
  print(printQuestionsRight);
}

function print(message) {
  document.write(message);
}
quiz(questions);

Fiddle Demo

answered May 27, 2016 at 10:36

Rayon

36.6k5 gold badges54 silver badges78 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Rayon Over a year ago

@Austin, I'm glad it helped! Happy Coding

Neil Cooper · Accepted Answer · 2016-05-27 10:50:55Z

As a starter, instead of re-declaring variables for the correct and incorrect answers. Push the questions onto the variables each time they answer:

var questions = [
  ['How many states are in the United States?', '50'],
      ['How many legs does a spider have?', '8'],
      ['How many continents are there?', '7']
    ],
    correctAnswers = [],
    wrongAnswers = [];

    function quiz(quizQuestions) {
      var counter = 0;
      
      for (var i = 0; i < questions.length; i++) {
        var answer = prompt(questions[i][0]);
        
        if (answer === questions[i][1]) {
          correctAnswers.push ([questions[i][0]]);
          counter += 1;
        } else {
          wrongAnswers.push ([questions[i][0]]);
        }
      }

      print('<h2>You got these questions right</h2>');
      print(correctAnswers);
      print('<h2>You got these questions wrong</h2>');
      print(wrongAnswers);
      
      var printQuestionsRight = '<h3>You got ' + counter + ' questions right</h3>';
      print(printQuestionsRight);
    }

    function print(message) {
      document.write(message);
    }

    quiz(questions);

Collectives™ on Stack Overflow

Simple JavaScript quiz array issue

2 Answers 2

Fiddle Demo

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related