unable to get value of a variable inside a string : angularjs

Question

I am unable to get the value of a variable in following case :

onclick="window.location.href = '#/app/tmnl/{{ message.pid }}' "

it just prints this to '#/app/tmnl/{{ message.pid }}' instead to taking the value of message.pid

<div ng-repeat="message in userMessages track by $index">
            <a class="item item-avatar" href="#">
                <img src="https://graph.facebook.com/{{ message.a1id }}/picture?type=square">
                <h2>{{ message.mdata.a1n }}</h2>
                <p>Back off, man. I'm a scientist.</p>
                <button class="button button-small button-positive" href="#/app/tmnl/{{ message.pid }}" onclick="window.location.href = '#/app/tmnl/{{ message.pid }}' ">
                    View
                </button>
            </a>
        </div>

Can anyone tell me the mistake i am making ?

You have put it as a string: '#/app/tmnl/{{ message.pid }}'. Do something like {{ '#/app/tmnl/' + message.pid }} instead — devqon
– devqon, Commented May 26, 2016 at 7:41

devqon · Accepted Answer · 2016-05-26 07:42:58Z

1

You have put the {{ }} in a string, so angular won't evaluate that. Do something like this instead:

onclick="window.location.href = {{ '#/app/tmnl/' + message.pid }}"

answered May 26, 2016 at 7:42

devqon

14k2 gold badges32 silver badges46 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

abhinsit · Accepted Answer · 2016-05-26 08:25:38Z

0

It worked when i replaced onclick to ng-click

ng-click="window.location.href = '#/app/tmnl/{{ message.pid }}' "

Thanks everyone for other answers as well

answered May 26, 2016 at 8:25

abhinsit

3,2574 gold badges23 silver badges26 bronze badges

3 Comments

Nikhilesh K V Over a year ago

You should not be using window.location.href. It will reload the entire page. If you want Single page application behavior this is not the right way.

abhinsit Over a year ago

What should i do then? a sref change ?

Nikhilesh K V Over a year ago

either ng-href or sref would be the correct way. Try using my answer in this way : <button><a ng-href="#/app/tmnl/message.pid">Button Text</a></button>

Collectives™ on Stack Overflow

unable to get value of a variable inside a string : angularjs

2 Answers 2

Comments

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest