adding 2 object arrays in C#

Question

I have 2 arrays of objects and I want to add one to the other. This seems simple enough but nothing seems to work. Here is what I am trying now.

Module[] StaticModules;
Module[] DynamicModules;

Info = Database.Devices[inx];
//Modules = Database.GetDeviceModules(Info);

StaticModules = Database.GetDeviceModules(Info);
DynamicModules = Database.GetDeviceModules(new int[] { 23, 24, 25, 26, 27, 28, 29, 30 });

Array.Resize(ref StaticModules, StaticModules.Length + DynamicModules.Length);
Array.Copy(StaticModules, DynamicModules, DynamicModules.Length);

Modules = StaticModules;

Everything seems ok until the copy which seems to take forever and doesn't appear to do a thing. At one point I had the watch window open and after the copy all my vars turned red and I saw a message that said I had to refresh because the last function timed out.

the first parameter to Copy should be the source, your resize call suggests you think it is the destination. — muratgu
– muratgu, Commented May 18, 2016 at 18:42
You are trying to copy the DynamicModules values into StaticModules, is that correct? — Sven Grosen
– Sven Grosen, Commented May 18, 2016 at 18:47
Do you have to use arrays or can use more dynamic structures like List? — D Stanley
– D Stanley, Commented May 18, 2016 at 18:50

Meta-Knight · Accepted Answer · 2016-05-18 18:51:52Z

3

Your code seems overly complicated. Why not do:

Modules = StaticModules.Concat(DynamicModules).ToArray();

answered May 18, 2016 at 18:51

Meta-Knight

17.9k1 gold badge51 silver badges60 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

lusher00 Over a year ago

I tried the concat route but I couldn't get that to work either. I'll try what you suggest here. I think i was doing Modules.Concat(DynamicModules) and not seeing any change.

Pavel Pykhtin · Accepted Answer · 2016-05-18 18:48:19Z

Array.Copy method has several overloads. You might need to use this one Array.Copy. The overload you chose overwrites elements of the destination array as they pastes items starting form index 0. Also as @muratgu said first argument is the source array.

Module[] StaticModules;
    Module[] DynamicModules;

    Info = Database.Devices[inx];
    //Modules = Database.GetDeviceModules(Info);

    StaticModules = Database.GetDeviceModules(Info);
    var len = StaticModules.Length;

    DynamicModules = Database.GetDeviceModules(new int[] { 23, 24, 25, 26, 27, 28, 29, 30 });



    Array.Resize(ref StaticModules, StaticModules.Length + DynamicModules.Length);
    Array.Copy(DynamicModules, 0, StaticModules, len, DynamicModules.Length);

    Modules = StaticModules;

vohrahul · Accepted Answer · 2016-05-18 18:54:01Z

1

You can use CopyTo for this.

Module[] StaticModules;
Module[] DynamicModules;
Module[] FinalModules = new Module[StaticModules.Length + DynamicModules.Length];

StaticModules.CopyTo(FinalModules, 0);
DynamicModules.CopyTo(FinalModules, StaticModules.Length);

answered May 18, 2016 at 18:54

vohrahul

1,22112 silver badges17 bronze badges

Comments

Justin Lam · Accepted Answer · 2016-05-18 18:54:53Z

0

This should work for you. I tried it in a compiler to see the results.

Array.Copy(DynamicModules, 0, StaticModules, DynamicModules.Length, DynamicModules.Length);

Full code:

Module[] StaticModules;
Module[] DynamicModules;

Info = Database.Devices[inx];
//Modules = Database.GetDeviceModules(Info);

StaticModules = Database.GetDeviceModules(Info);
DynamicModules = Database.GetDeviceModules(new int[] { 23, 24, 25, 26, 27, 28, 29, 30 });

Array.Resize(ref StaticModules, StaticModules.Length + DynamicModules.Length);
Array.Copy(DynamicModules, 0, StaticModules, DynamicModules.Length, DynamicModules.Length);

Modules = StaticModules;

answered May 18, 2016 at 18:54

Justin Lam

7995 silver badges8 bronze badges

Collectives™ on Stack Overflow

adding 2 object arrays in C#

4 Answers 4

1 Comment

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related