making http requests in nodejs loop

Question

Finding it almost impossible to capture the response of http requests in a loop as an array. I can see the array in console.log but when I pass the array to be the response of http server I get a blank array. What am I doing wrong , or are there better ways to do this?

Code :

router.route('/uprns').post(function(request, response){
  response.setHeader('content-type', 'application/text');

  console.log('first element from the array is '+request.body.UPRNS[0]);
  console.log('Number of items in array is '+request.body.UPRNS.length);

if (request.body.UPRNS.length == 0) {
         response.send( 'no UPRNS in request' );
    }

  var output = [];
  var obj = '';

  for( var i = 0; i < request.body.UPRNS.length; i++) {

    obj = request.body.UPRNS[i];

    //Make  HTTP calls to     
    var options = {
      host: 'orbisdigital.azure-api.net',
      path: '/nosecurity/addresses?uprn='+obj // full URL as path
    };

    callback = function(res) {    
      res.on('data', function (chunk) {
        output.push(chunk.toString());
      });

      //the whole response has been recieved
      res.on('end', function () {
        console.log(output);
      });
    }

    Https.request(options, callback).end();
  }

  response.send(output);

});

I know there is a lot of talk about blocking process in a for loop , but there is no definitive recommended way to deal with http calls in a loop. Thank you .

The order of elements in the output array is important? Should he comply with the order of http-requests? — stdob--
– stdob--, Commented Apr 29, 2016 at 8:32
The order is not important in my case , but would like to know how to achieve the order as well . — noexpert
– noexpert, Commented Apr 29, 2016 at 9:18

Community · Accepted Answer · 2017-05-23 11:59:34Z

1

Here is the code. See the code for the added comments. Do some reading on asynchronous programming with node.js, here's a starter.

router.route( '/uprns' ).post( function ( request, response ) {
    response.setHeader( 'content-type', 'application/text' );
    console.log( 'first element from the array is ' + request.body.UPRNS[ 0 ] ); // your  1st element in  JSON array.

    console.log( 'Number of items in array is ' + request.body.UPRNS.length );
    var output = [];
    var obj = '';

    for ( var i = 0; i < request.body.UPRNS.length; i++ ) {

        obj = request.body.UPRNS[ i ];

        console.log( obj );

        //Make  HTTP calls to

        var options = {
            host: 'orbisdigital.azure-api.net',
            path: '/nosecurity/addresses?uprn=' + obj // full URL as path
        };

        Https.request( options, callback ).end();

    }

    var countResponses = 0;
    // Don't make functions in a loop, so I moved this function down
    // here.
    function callback( res ) {

        res.on( 'data', function ( chunk ) {
            output.push( chunk.toString() );
        });

        // Handles an error
        request.on('error', function(err) {
          console.error(err.stack);
          response.statusCode = 500; // or what ever.
          response.send(500, 'there was an error');
        });

        //the whole response has been recieved
        res.on( 'end', function () {
            console.log( output );
            countResponses++;
            if (countResponses === request.body.UPRNS.length) {

                // Previously this code was executed directly 
                // after the loop finished.  It did not wait for
                // all the responses, so it sent the empty response.
                // However, the other console.log(output) statements
                // were called after this.
                //
                // There is a bug here that if request.body.UPRNS.length
                // is zero, then the user will never get a response.  I 
                // let you fix this up :).
                response.send( output );
            }
        } );

    }

} );

edited May 23, 2017 at 11:59

CommunityBot

11 silver badge

answered Apr 29, 2016 at 8:40

psiphi75

2,0641 gold badge25 silver badges37 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

psiphi75 Over a year ago

@stdob: Yes, good point, I will add. Also when request.body.UPRNS.length is zero, Ieave this up the person asking.

noexpert Over a year ago

Great , worked like a charm . will work on handling null requests.Thanks for your help.

noexpert Over a year ago

added a simple if condition to deal with empty input array . added to original code. if (request.body.UPRNS.length == 0) { response.send( 'no UPRNS in request' ); }

Phagun Baya · Accepted Answer · 2016-04-29 08:52:34Z

0

Better way to handle such scenario is to use async.js instead of for loops. https://github.com/caolan/async

answered Apr 29, 2016 at 8:52

Phagun Baya

2,2572 gold badges20 silver badges28 bronze badges

Collectives™ on Stack Overflow

making http requests in nodejs loop

2 Answers 2

3 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related