UNIX: error when I try to use array

Question

I have this code and when I try it in FreeBSD it shows me a lot of errors... how can I fix it? I check directories, if it match with variable IGN. NAME_d should be an array.

max_d=$(find "${DIR}" -type d | wc -l)

for i in `seq 1 $max_d`
do
  check_d=$(find "${DIR}" -type d | head -n "${i}" | tail -n -1 | tr '\/' '\n' | egrep -n "${IGN}")

  if [ ! -z "$check_d" ]; then

    NAME_d+=$i"d "

  fi

done

directory_d=${NAME_d[*]}
sedCmds_d=${directory_d// /;}

this is the second time today I see this seq loop with a previous find and another find in the loop reading only one line from each find. This is far from optimal. Rethink your work! How about let x=0; find . -type d | while read dir; do let 'x++'; DO YOUR WORK WITH $dir HERE, POSSIBLY ALSO USING LINENO $x.; done — ikrabbe
– ikrabbe, Commented Mar 28, 2016 at 18:17
You don't appear to be using bash, which has allowed += for assignment statements since version 3.1. In addition, NAME_d is not an array even if you were using bash. — chepner
– chepner, Commented Mar 28, 2016 at 18:17
Provide information as image iff they can't be posted as text (readable, searchable, etc). — Kalle Richter
– Kalle Richter, Commented Mar 28, 2016 at 18:24

kamikaze · Accepted Answer · 2016-03-28 18:30:43Z

1

Arrays are a bashism not supported by the Almquist shell, the default bourne style shell on FreeBSD (i.e. /bin/sh). An advantage of the shell is that most scripts run about 3 times faster.

If you want to use bashisms, use bash to execute your script. E.g. call it bash dirstat.sh or change the shebang.

This is the correct one for FreeBSD.

#!/usr/local/bin/bash

This is the portable version but requires PATH to be set:

#!/usr/bin/env bash

You also might have to install bash first: pkg add bash

answered Mar 28, 2016 at 18:30

kamikaze

1,5891 gold badge8 silver badges18 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Marcin Zukowski · Accepted Answer · 2016-03-28 18:19:21Z

1

Not sure if it will solve it, but if you're using bash, you should initiate NAME_d as an array

NAME_d=()

and then adding to the array you should also use parens, e.g.

NAME_d+=("${i}d ")

answered Mar 28, 2016 at 18:19

Marcin Zukowski

4,8391 gold badge25 silver badges31 bronze badges

Collectives™ on Stack Overflow

UNIX: error when I try to use array

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related