AngularJS Call function from another file

Question

When I trying call function from another file I get error:

TypeError: Cannot read property 'getCurrentUserFullName' of undefined

in app.js:

    'use strict';

    var testApp = {};

    var App = angular.module('testApp', ['testApp.filters', 'testApp.services', 'testApp.directives',
            'ngRoute']);

    App.run(['$location', '$rootScope', function ($location, $rootScope) {

        $rootScope.$on("$routeChangeSuccess", function (event, currentRoute, previousRoute, AuthUtils) {
           if(!$rootScope.userFullName){
                var userFullName = AuthUtils.getCurrentUserFullName();
                if(userFullName) {
                    $rootScope.userFullName = userFullName;
                    $rootScope.authenticate = true;
                } else {
                    $rootScope.authenticate = false;
                    $rootScope.userFullName = "";
                }
            }
        });

    }]);

AuthUtils.js

    'use strict';

    angular.module('testApp')
        .factory('AuthUtils', function AuthUtils($rootScope, $http) {
            return {
                getCurrentUserFullName: function () {
                    $http.get('auth/userFullName').success(function (user) {
                        return user;
                    }).error(function (data, status) {
                        return "error";
                        console.error(status, data);
                    });
                }
            };
        });

Why doesn't work?

Pankaj Parkar · Accepted Answer · 2016-03-17 21:42:22Z

3

You missed to inject AuthUtils inside run block. Inject it so factory instance would be available in run block

App.run(['$location', '$rootScope', 'AuthUtils', //<== injected AuthUtils here
    function ($location, $rootScope, AuthUtils) { //<== and here

Additonally you need to remove AuthUtils parameter from $routeChangeSuccess function, which was killing existence of injected AuthUtils in run block.

Change to

$rootScope.$on("$routeChangeSuccess", function (event, currentRoute, previousRoute) //<--removed AuthUtils

From

$rootScope.$on("$routeChangeSuccess", function (event, currentRoute, previousRoute, AuthUtils)

edited Mar 17, 2016 at 21:42

answered Mar 17, 2016 at 21:23

Pankaj Parkar

136k23 gold badges241 silver badges307 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Pablo Over a year ago

Thank you very much, but now I've an error "Uncaught Error: [$injector:unpr] errors.angularjs.org/1.5.0/$injector/…"

Pablo Over a year ago

Thank you, I did as above and I changed order import js files and works!

Pankaj Parkar Over a year ago

@Pablo glad to know that.. do upvote & accept answer..if it does helped you.. Thanks :-)

Collectives™ on Stack Overflow

AngularJS Call function from another file

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related