while loop not working in Java

Question

I am trying to get this to ask the question over and over again while the user inputs a 'Y'. and stop and return the Event.displayFinalResults(); when the user inputs a 'N'

i am getting a continuous loop right now. I am missing something or my layout it wrong. Any help would be great.

            System.out.println("Is there anymore amounts you want to add?(Y/N): ");
            Scanner keyboard = new Scanner(System.in);
            char choice = keyboard.next().charAt(0);
            choice = Character.toUpperCase(choice);
            if(choice == 'Y')
            {
                do
                {
                    System.out.println("Is there anymore amounts you want to add?(Y/N): ");
                    choice = keyboard.next().charAt(0);
                    choice = Character.toUpperCase(choice);

                    readValidateAmountType();
                    readValidateAmount(); 
                }
                while(choice =='Y');

            }
            else
            {
                Event.displayFinalResults();
            }

thanks again.

Just to be clear, the problem is that after you type in Y first, then type in N next, it stays in the while loop? — Michael
– Michael, Commented Feb 22, 2016 at 4:21
It's comparing characters, not strings, so I don't think that's the issue. — Michael
– Michael, Commented Feb 22, 2016 at 4:22
i am new. so i know i have a continuous loop because of a tiny problem. I have been working on this for hours trying different methods and now i am at a roadblock. — Luke8h
– Luke8h, Commented Feb 22, 2016 at 4:24
Yes @Michael that is correct. if you answer N first, then it works fine, but if you answer Y then N, then your in the loop — Luke8h
– Luke8h, Commented Feb 22, 2016 at 4:28
@Luke8h, Why are you doing duplicate code for input? for example System.out.println("Is there anymore amounts you want to add?(Y/N): "); writing twice! — mmuzahid
– mmuzahid, Commented Feb 22, 2016 at 4:43

Andreas · Accepted Answer · 2016-02-22 04:30:01Z

You program asks a Yes/No question, then if you answer Yes, it enter a loop which starts by asking the same question again, before asking for the amount value.

You might want to ask for the amount value before asking the Yes/No question again.

If user answer No, the loop will exit (after asking for one more amount value), but Event.displayFinalResults() will not be executed. Drop the else clause, so Event.displayFinalResults() whether it entered the if statement or not.

System.out.println("Is there anymore amounts you want to add?(Y/N): ");
Scanner keyboard = new Scanner(System.in);
char choice = keyboard.next().charAt(0);
choice = Character.toUpperCase(choice);
if (choice == 'Y')
{
    do
    {
        readValidateAmountType();
        readValidateAmount(); 

        System.out.println("Is there anymore amounts you want to add?(Y/N): ");
        choice = keyboard.next().charAt(0);
        choice = Character.toUpperCase(choice);
    }
    while(choice =='Y');
}
Event.displayFinalResults();

mmuzahid · Accepted Answer · 2016-02-22 04:31:35Z

2

You could do this using break; as follows:

do {
    System.out.println("Is there anymore amounts you want to add?(Y/N): ");
    choice = keyboard.next().charAt(0);
    choice = Character.toUpperCase(choice);
    if (choice !='Y') {
        break;
    }

    readValidateAmountType();
    readValidateAmount(); 
} while(true);

Event.displayFinalResults();

answered Feb 22, 2016 at 4:31

mmuzahid

2,28025 silver badges45 bronze badges

Comments

Priyath Gregory · Accepted Answer · 2016-02-22 04:28:28Z

One problem I see with this is, your while loop is inside the if statement. Once you exit the while loop, it's NOT going to run the code inside the else block because the if condition was already true.

So try removing the else block. This will make sure the Event.displayFinalResults method is called once the while loop exits.

     System.out.println("Is there anymore amounts you want to add?(Y/N): ");
        Scanner keyboard = new Scanner(System.in);
        char choice = keyboard.next().charAt(0);
        choice = Character.toUpperCase(choice);

if(choice == 'Y')
        {
            do
            {
                System.out.println("Is there anymore amounts you want to add?(Y/N): ");
                choice = keyboard.next().charAt(0);
                choice = Character.toUpperCase(choice);

                readValidateAmountType();
                readValidateAmount(); 
            }
            while(choice =='Y');

        }

        Event.displayFinalResults();

SkyMaster · Accepted Answer · 2016-02-22 04:42:32Z

0

Clear code and compact:

Scanner keyboard = new Scanner(System.in);
char choice;
do {
   System.out.println("Is there anymore amounts you want to add?(Y/N): ");
   choice = keyboard.next().charAt(0);
   choice = Character.toUpperCase(choice);
   if(choice == 'Y') {
      readValidateAmountType();
      readValidateAmount(); 
   }
} while(choice == 'Y');     
Event.displayFinalResults();

answered Feb 22, 2016 at 4:42

SkyMaster

1,3231 gold badge8 silver badges15 bronze badges

Comments

Tom Piaggio · Accepted Answer · 2016-02-22 04:39:38Z

-1

Try the following out:

    public void answering(char answer){
        if(answer == 'Y' || answer == 'y'){
            System.out.println("Answering");
        } else if(answer == 'N' || answer == 'n'){
            System.out.println("Not answering");
    }

Instead of looping, call this method when you want to ask...

answered Feb 22, 2016 at 4:39

Tom Piaggio

6691 gold badge8 silver badges28 bronze badges

Collectives™ on Stack Overflow

while loop not working in Java

5 Answers 5

Comments

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related