Why will this program not sort the array?

Question

I am aware that there is a sort function available in C# to sort arrays into the correct order, but for reasons, I need to do it with my own code.

I have come up with this, and some of the numbers move, but it never fully sorts. Has anyone any idea why?

static void Main(string[] args)
    {
        int[] arraySort = { 2, 5, 7, 3, 6, 3 };
        int save;
        bool sorted = false;

        while(sorted == false) {
            for (int i = 0; i < (arraySort.Length - 1); i++)
            {
                sorted = true;
                if (arraySort[i] > arraySort[i + 1])
                {
                    save = arraySort[i];
                    arraySort[i] = arraySort[i + 1];
                    arraySort[i + 1] = save;
                    sorted = false;
                }
            }
        }

        for (int i = 0; i < arraySort.Length; i++)
        {
            Console.WriteLine(arraySort[i]);
        }
    }

My output ends up being:

2 3 5 3 6 7

sorted = true; mis-placed.

user1196549
– user1196549

2015-09-29 16:20:39 +00:00
Commented Sep 29, 2015 at 16:20 — user1196549
– user1196549, Commented Sep 29, 2015 at 16:20

James · Accepted Answer · 2015-09-29 16:22:06Z

2

You set sorted = true inside the for loop.

So it stops as soon as the penultimate entry is less than the final entry. All other checks are ignored when validating the outer loop

answered Sep 29, 2015 at 16:22

James

10k5 gold badges38 silver badges63 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

David Constantine · Accepted Answer · 2015-09-29 16:25:02Z

2

You set sorted=true every item you iterate, You need to do sorted=true outside of the for loop, between the while and the for.

while (sorted == false) {
            sorted = true;// here seems like the right place!
            for (int i = 0; i < (arraySort.Length - 1); i++)
            {     
                if (arraySort[i] > arraySort[i + 1])
                {
                    save = arraySort[i];
                    arraySort[i] = arraySort[i + 1];
                    arraySort[i + 1] = save;
                    sorted = false;
                }
            }
        }

answered Sep 29, 2015 at 16:25

David Constantine

5875 silver badges10 bronze badges

Comments

DerekB · Accepted Answer · 2015-09-29 16:39:05Z

-1

Why not just do:

arraySort = arraySort.OrderBy(x => x).ToArray();

answered Sep 29, 2015 at 16:39

DerekB

111 bronze badge

1 Comment

Joe Over a year ago

Because... he stated in his question, that for reasons he didn't want to go into, he needs to do this in his own code, as opposed to a quick one-line solution.

Collectives™ on Stack Overflow

Why will this program not sort the array?

3 Answers 3

Comments

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related