jquery array question

Question

I have the following :

<script>
$().ready(function() {

 $("#myVal#").blur(function() {
   var arr = jQuery.makeArray(  $("#myArr").val() )
if ( $("#myVal").val().indexOf(arr) == -1 || $("#myVal").val().indexOf(arr) ==0) {
    arr.push($("#myVal").val());
}
$("#myArr").val(arr)
});
});
</script>
<form action="" method="post" name="myF" id="myF">
 <input type="text" name="myVal" id="myVal" value="">
 <input type="text" name="myArr" id="myArr" value="">
 <br/>
<input type="submit" name="submit" id="submit" value="go">
</form>

I am trying to check and see if a particular value entered to myVal is already in myArr. If so, don't add to the array. If not, then add to the array. However, the array keeps growing with duplicate values.

what am i doing wrong?

thanks in advance.

jigfox · Accepted Answer · 2010-07-16 15:55:22Z

2

try changing

 $("#myVal#").blur(function() {
         ^^^

with

 $("#myVal").blur(function() {
         ^^^

answered Jul 16, 2010 at 15:55

jigfox

18.2k3 gold badges62 silver badges74 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Matthew Flaschen · Accepted Answer · 2010-07-16 16:01:08Z

1

First, makeArray is meant to take array-like objects as input, not strings. And I don't see the purpose here. If you have an actual array arr (perhaps made using split), you can do:

if ( $.inArray($("#myVal").val(), arr) == -1)

Your current code calls String.indexOf(arr), so arr is implicitly converted to a (comma-separated)string. Then you search for the array string in the new value. This is clearly not what you want.

edited Jul 16, 2010 at 16:01

answered Jul 16, 2010 at 15:55

Matthew Flaschen

286k53 gold badges523 silver badges554 bronze badges

Comments

Nick Craver · Accepted Answer · 2010-07-16 16:01:19Z

1

I believe what you're after is something like this using $.inArray():

$(function() {
 $("#myVal").blur(function() {
   var arr = $("#myArr").val().split(',');
   if ($.inArray($("#myVal").val(), arr) == -1) arr.push($("#myVal").val());
   $("#myArr").val(arr.join(','));
 });
});

Try a demo here, now this would break if the value had a comma...just choose an appropriate delimiter. What this is going is taking the string out, calling .split() to turn it into an array, splitting the items at the provided delimiter, adding the value if it's missing ($.inArray() returns the postion of the element, -1 if it's not found). Then we're just calling .join() with the same delimiter to turn it back into a string.

answered Jul 16, 2010 at 16:01

Nick Craver

631k138 gold badges1.3k silver badges1.2k bronze badges

Comments

Ankur · Accepted Answer · 2012-11-18 08:12:16Z

0

this did the trick :

$().ready(function () {
     var arr = [];
     $("#myVal").blur(function () {
         if ($.inArray($('#myVal').val(), arr) == -1) {
             arr.push($("#myVal").val());
         }
         $("#myArr").val(arr);
     });
});

edited Nov 18, 2012 at 8:12

Ankur

12.8k7 gold badges40 silver badges68 bronze badges

answered Jul 16, 2010 at 16:07

Kung Fu Ninja

3,7905 gold badges41 silver badges61 bronze badges

Collectives™ on Stack Overflow

jquery array question

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related