Delete mySql row with PHP

Question

I have shop site and want to be able delete what I add but can't seem to get it to work.

All relevant code is below:

Home page:

<?php
  //external pages area
  include_once('config/database.php');
  include_once('object/chair.php');
  //grabs info from the various pages.sql files
  $database = new Database();
  $conn = $database->getConnection();
  $chair = new Chair($conn);
  //connection made with sql file
  $stmt = $chair->readAll();
  //reading all the data in the sql file
  while($row = $stmt->fetch(PDO::FETCH_ASSOC)){
?>
    <div class="ProductActionAdd" style="display:;">
      <a href="chair-details.php?detailsid=<?php echo $row['ID'];?>" class="btn">Buy me!</a>
    </div>

Details page:

<?php
  include_once('config/database.php');
  include_once('object/chair.php');
  $database = new Database();
  $conn = $database->getConnection();
  $chair = new Chair($conn);
  $chair->id = $_GET['detailsid'];
  $stmt = $chair->readDetails();
  while($row = $stmt->fetch(PDO::FETCH_ASSOC)){
?>
    <a href='delete-chair.php?detailsid=<?php echo $row['ID'];?>' class="deleteit">deleate</a>

Delete page:

<?php
  include_once('config/database.php');
  include_once('object/chair.php');
  $database = new Database();
  $conn = $database->getConnection();
  $chair = new Chair($conn);
  $chair->id = $_GET['detailsid'];
  $stmt = $chair->readAll();
  while($row = $stmt->fetch(PDO::FETCH_ASSOC)){
?>
    <div class="center_items">
      <div class="all-items">
        <?php   
          $sql="DELETE FROM office_chairs WHERE id ='{$chair->id}'";    
  }
        ?>

It states that detailsID is undefined and that Object of class chairs can't be converted into a string.

faerin · Accepted Answer · 2015-09-13 18:26:57Z

Well... you're receiving the detailsid parameter through $_GET and then you appoint it to a property called id.

$chair->id = $_GET['detailsid'];

Thus, calling a variable with the name $detailsid is not possible - cause no such variable exist. Use the property you assigned the value too instead.

The $chair variable contains a new instance of the class Chair. I don't know what your intentions are? Is the database table name dynamic? If not, just write the table name.

Correcting your query from

$sql="DELETE FROM $chair WHERE id = '$chair->id'";

to:

$sql="DELETE FROM table_name_here WHERE id ='$detailsid'";

might fix your problem giving the result you wish for. But your code is vulnerable to SQL injections. You should consider using prepared statments instead of directly connecting the variables to your query.

For example

$sql="DELETE FROM table_name_here WHERE id = ?";
$stmt -> $con = prepare($sql);
$stmt -> execute(array($chair -> id));

Venkat Papana · Accepted Answer · 2015-09-13 18:31:37Z

1

Update

$sql="DELETE FROM $chair WHERE id ='$detailsid'";

to

$sql="DELETE FROM chair WHERE id ='{$chair->id}'";

answered Sep 13, 2015 at 18:31

Venkat Papana

4,96713 gold badges57 silver badges82 bronze badges

Collectives™ on Stack Overflow

Delete mySql row with PHP

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related