Display Array with additional input in between

Question

I have an Array with some numeric values. I want to display them but I also have a user input which should be displayed after the respective element in the array. My approach works fine but seems really overcomplicated to me. I created a fiddle:

http://jsfiddle.net/sjoy8p59/1/

var numbers = [2, 4, 8, 12, 42, 120, 612, 69];
var input = 32;
var flag = false;
var output = "";

for (i = 0; i < numbers.length; i++) {
    if (numbers[i] < input) {
        output += numbers[i]+", ";
    } else {
        if (flag == false) {
            output += input + ", ";
            flag = true;
        } else {
            output += numbers[i]+", ";
        }
    }
}
document.getElementById("output").innerHTML = output;

So the value 32 from input should be displayed after the 12 and before the 42 from the array. I use a for loop and a boolean with an if clause to detect whether the Array element is larger or smaller than the input and then add it all together and display it.

How can I do it better and cleaner?

EDIT: I figured out there is a mistake in my code because it skipped one element in the array

The array you've provided isn't sorted - if you sort the array every time you push an element to it, then it'll be at the right place :) — jonny
– jonny, Commented Sep 12, 2015 at 20:46
Is it better to add the input to the array first and then display it or directly display the array and put the input somewhere in there? — ua1
– ua1, Commented Sep 12, 2015 at 20:49
Where should the value be added in the array? And is the array always sorted? For example, where should 32 be added in the following array: [2,12,42,612,3,13,43] — user1176420
– user1176420, Commented Sep 12, 2015 at 20:49
Oh i understand there is a mistake in my logic...yes the array must be sorted and then the input must been added to the right place like array element < input < array element — ua1
– ua1, Commented Sep 12, 2015 at 20:54

Zakaria Acharki · Accepted Answer · 2015-09-12 20:57:04Z

2

Working fiddle.

You can do it using push() to add your input to the Array, and use simple function sortNumber() to sort it.

JS :

var numbers = [2, 4, 8, 12, 42, 120, 612, 69];
var input = 32;

numbers.push(input); //add 32 to the array

function sortNumber(a,b) {
    return a - b;
}

numbers.sort(sortNumber); //Sort Array
document.getElementById("output").innerHTML = numbers.join(","); //Display result

var numbers = [2, 4, 8, 12, 42, 120, 612, 69];
var input = 32;

numbers.push(input); //add 32 to the array

function sortNumber(a,b) {
  return a - b;
}

numbers.sort(sortNumber);

alert(numbers.join(","));

Hope this helps.

edited Sep 12, 2015 at 20:57

answered Sep 12, 2015 at 20:51

Zakaria Acharki

67.5k15 gold badges79 silver badges106 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

baao · Accepted Answer · 2015-09-12 20:54:24Z

2

I'd just sort them:

var numbers = [2, 4, 8, 12, 42, 120, 612, 69];
var input = 32;
numbers.push(input)
numbers.sort(function(a,b){return a-b});
document.getElementById("output").innerHTML = numbers.join(', ');

<div id="output"></div>

answered Sep 12, 2015 at 20:54

baao

73.5k18 gold badges152 silver badges208 bronze badges

Comments

Michael Fulton · Accepted Answer · 2015-09-12 20:57:15Z

0

https://jsfiddle.net/sjoy8p59/3/

var numbers = [2, 4, 8, 12, 42, 120, 612, 69];
var input = 32;
var flag = false;
var output = "";

for (i = 0; i < numbers.length; i++) {
    if (numbers[i] < input || flag == true) {
        output += numbers[i]+", ";
    } else {
        output += input + ", ";
        flag = true;
        i--
    }
}
document.getElementById("output").innerHTML = output;

I edited your jsfiddle with minimal edit to your code, although the sort methods look cleaner.

answered Sep 12, 2015 at 20:57

Michael Fulton

5,0003 gold badges29 silver badges42 bronze badges

Collectives™ on Stack Overflow

Display Array with additional input in between

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related