Cannot modified checkbox with javascript

Question

I have this code in html I want to change the checkbox check and uncheck event using javascript on some event so I am calling function ChangeCheckBox() on button click

<div>
    <label class="checkbox line">
        <input type="checkbox" id="Add" />Add</label>
</div>
<script>
    function ChangeCheckBox() {
        var AddCheck = 0;
        if (AddCheck == 1) {
            document.getElementById("Add").checked = true;
        } else {
            document.getElementById("Add").checked = false;
        }
    }
</script>

So in above condition check box should unchecked but its not happening checkbox is remaining checked after running this code

the if block is redundant. The if wont execute ever as you are setting AddCheck = 0 always in this function.It will always land in the else block — cafebabe1991
– cafebabe1991, Commented Sep 2, 2015 at 8:03
Its just a piece if code i posted is to understand actual code AddCheck is dynamic and it sets according to some conditions — Kirtesh
– Kirtesh, Commented Sep 2, 2015 at 8:07

Roland Mai · Accepted Answer · 2015-09-02 08:05:44Z

3

Since you are setting AddCheck = 0;, of course it will not keep it's state, because you are reseting the value. If you want to simulate a toggle, here's a simpler alternative.

<script>
    function ChangeCheckBox() {
        var el = document.getElementById("Add");
        el.checked = !el.checked;
    }
</script>

answered Sep 2, 2015 at 8:05

Roland Mai

31.2k8 gold badges58 silver badges61 bronze badges

Sign up to request clarification or add additional context in comments.

9 Comments

Kirtesh Over a year ago

Ok there is not problem with my if box the values are ruuning perfectly this is a sample code to understand my problem. Actual code differs. My problem is just i cannot programitically check uncheck the check boxes.

Roland Mai Over a year ago

@Snehal I am not sure what the actual problem is then. It sounds like a logic error. Here's a fiddle jsfiddle.net/vsxa8gf3 to help you out.

Kirtesh Over a year ago

Dude its 100% not a logical error it is a syntax error

Kirtesh Over a year ago

This is the fiddle jsfiddle.net/kirtesh08/okbc5vb9 I dont know its not working properly but I explain the functionality when click on Second Level it pageId will go in textbox below permissions from there we can select the permissions and when on clcik of second page the permission will go as per selection

Kirtesh Over a year ago

Even i tried u r code with mine code but its not toggleing the check box u can see the same code in fiddle

|

Clad07 · Accepted Answer · 2015-09-02 08:08:23Z

0

How do you link 'ChangeCheckBox()' to your button ? Can you post this code too ?

The problem is probably because the button refresh your page and so, the checkbox return to it initial state.

answered Sep 2, 2015 at 8:08

Clad07

12 bronze badges

1 Comment

Kirtesh Over a year ago

<a href=# onclick=ChangeCheckBox()>Change</a> I guess there is no refreshing problem

Collectives™ on Stack Overflow

Cannot modified checkbox with javascript

2 Answers 2

9 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

9 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related