Incrementing a dynamic variable in PowerShell

Question

I have a variable in PowerShell that I use to create a list of other variables all set to zero like so:

$DivList= "A", "B", "C"
Foreach($Div in $DivList)
{
    New-Variable -Name "P1$div" -Value 0
    New-Variable -Name "E1$div" -Value 0
    New-Variable -Name "E3$div" -Value 0
}

I use these variables to do a count of what type of licenses we have. So I then iterate through each of the divisions, and I want to simply add 1 to the proper variable if the user has that license and is in that division. So if user John has a P1 license and is in Div A then Variable P1A should increment up by 1.

$Users = get-msoluser -MaxResults 3000

Foreach ($user in $users)
{
    if($user.licenses.AccountSkuID -eq $P1)
    {
        ForEach($Div in $DivList)
        {
            if($user.Department -like $Div)
            {
                Set-Variable -Name "P1$Div" -Value ++
                $P1$Div ++
            }
        }

Above I have both the set-variable command and I tried $p1$Div ++. I can't figure out how to make the variable increment up. The Set-Variable command always sets the variable like it is a string value, so it will set it to "++" instead of moving it from 0 to 1.

mjolinor · Accepted Answer · 2015-08-12 21:17:22Z

2

I'd use a hash table for the counts, rather than discrete variables:

$DIVCounts = @{}
$DivList= "A","B","C"
Foreach($Div in $DivList)
{ 
  $DIVCounts["P1$div"] = 0
  $DIVCounts["E1$div"] = 0
  $DIVCounts["E3$div"] = 0
}

$Users = get-msoluser -MaxResults 3000 

Foreach ($user in $users)
{
    if($user.licenses.AccountSkuID -eq $P1)
    {
        ForEach($Div in $DivList)
        {
            if($user.Department -like $Div)
            {
                $DIVCountss["P1$Div"]++
            } 
        }

answered Aug 12, 2015 at 21:17

mjolinor

68.7k7 gold badges118 silver badges141 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

briantist · Accepted Answer · 2015-08-12 21:44:08Z

1

@mjolinor has a better approach so you should use that, but if you want to know why it's not working, it's because ++ is an operator and you're passing it into a cmdlet as a value.

You would actually have to do it like this with your approach:

$Users = get-msoluser -MaxResults 3000 

Foreach ($user in $users)
{
    if($user.licenses.AccountSkuID -eq $P1)
    {
        ForEach($Div in $DivList)
        {
            if($user.Department -like $Div)
            {
                #$newVal = (Get-Variable -Name "P1$Div").Value + 1
                #Set-Variable -Name "P1$Div" -Value $newVal
                ++(Get-Variable -Name "P1$Div").Value
                $P1$Div ++  
            } 
        }
    }
}

Edited thanks to PetSerAl's comment.

edited Aug 12, 2015 at 21:44

answered Aug 12, 2015 at 21:21

briantist

48.3k6 gold badges94 silver badges139 bronze badges

1 Comment

user4003407 Over a year ago

You can ++(Get-Variable -Name "P1$Div").Value. Value is read/write property.

Collectives™ on Stack Overflow

Incrementing a dynamic variable in PowerShell

2 Answers 2

Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related