JQuery in external .js file not running

Question

I am having problems running a simple jQuery script in an external js file.

$("#main-nav").click(function(){
   alert("hello");
});`

I declared the external js file here in my html after the jQuery file.

<script type="text/javascript" src="jquery.min.js"></script>
<script type="text/javascript" src="externalfile.js"></script>`

Nothing happens when I load the page and I get no errors in the console.

Welcome to Stack Overflow. For us to help you better, it would be useful if you included details such as what exact error or issue you are encountering, what you have tried to fix it, and any other information to give more context surrounding your problem. — Tim Radcliffe
– Tim Radcliffe, Commented Aug 5, 2015 at 14:16
move those scripts before closing body tag </body> and try running it if you are declaring those script tags in head — GaurabDahal
– GaurabDahal, Commented Aug 5, 2015 at 14:21

Mike · Accepted Answer · 2015-08-05 14:15:21Z

3

Taking a guess since there isn't enough information here, but I'm relatively certain you've placed these <script> tags in your <head>, where they will be executed before the DOM is ready. Since the DOM isn't ready, you can't bind a click event to it. Wrap your code in $(document).ready():

$(documment).ready(function () {
  $("#main-nav").click(function(){
    alert("hello");
  });
});

Now your code to bind the click handler will run after the DOM is ready and able to have events bound to it.

answered Aug 5, 2015 at 14:15

Mike

4,09125 silver badges36 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

JQuery in external .js file not running

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related