Run command from variables in shell script

Question

I wrote this piece of code to scan a directory for files newer than a reference file while excluding specific subdirectories.

#!/bin/bash

dateMarker="date.marker"
fileDate=$(date +%Y%m%d)
excludedDirs=('./foo/bar' './foo/baz' './bar/baz')
excludedDirsNum=${#excludedDirs[@]}

for (( i=0; i < $excludedDirsNum; i++)); do
    myExcludes=${myExcludes}" ! -wholename '"${excludedDirs[${i}]}"*'"
done

find ./*/ -type f -newer $dateMarker $myExcludes > ${fileDate}.changed.files

However the excludes are just being ignored. When I "echo $myExcludes" it looks just fine and furthermore the script behaves just as intended if I replace "$myExcludes" in the last line with the output of the echo command. I guess it's some kind of quoting/escaping error, but I haven't been able to eliminate it.

Philipp · Accepted Answer · 2010-06-30 15:41:48Z

1

Seems to be a quoting problem, try using arrays:

#!/bin/bash

dateMarker=date.marker
fileDate=$(date +%Y%m%d)
excludedDirs=('./foo/bar' './foo/baz' './bar/baz')
args=(find ./*/ -type f -newer "$dateMarker")
for dir in "${excludedDirs[@]}"
do
    args+=('!' -wholename "$dir")
done
"${args[@]}" > "$fileDate.changed.files"

Maybe you also need -prune:

args=(find ./*/)
for dir in "${excludedDirs[@]}"
do
    args+=('(' -wholename "$dir" -prune ')' -o)
done
args+=('(' -type f -newer "$dateMarker" -print ')')

answered Jun 30, 2010 at 15:41

Philipp

50.1k12 gold badges88 silver badges112 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

raphinesse Over a year ago

Thanks a lot for your answer. It works like a charm without the need of -prune.

ennuikiller · Accepted Answer · 2010-06-30 15:33:20Z

0

you need the myExcludes to evaluate to something like this:

$ -name foo/bar -o -name foo/baz -o -name bar/baz $

answered Jun 30, 2010 at 15:33

ennuikiller

47.1k15 gold badges115 silver badges137 bronze badges

Collectives™ on Stack Overflow

Run command from variables in shell script

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest