Dynamically changing javascript function for efficiency

Question

My question has to do with optimizing my javascript code to be more efficient.

I have a function that is called frequently but all the code inside is only needed to be called once, like so:

function removeBlankCanvas() {
    if ( --numberOfChartsStillLoading == 0 ) {
        //do stuff
    }
}

This works fine but the function is still called countless times after numberOfChartsStillLoading is 0, and I know it will never be 0 again. So I'm thinking about doing something like this:

function removeBlankCanvas() {
    if ( --numberOfChartsStillLoading == 0 ) {
        //do stuff

        removeBlankCanvas = function() {
            return true;
        }
    }
}

Could this be more efficient code? For instance, if the function was called millions of times? I'm asking strictly for curiosity's sake.

u.k · Accepted Answer · 2015-06-10 18:03:18Z

2

Your performance bottleneck is very unlikely to be a simple if statement.

This trick could actually cause unexpected result, because functions are immutable, and you are very likely to have callbacks that will keep a reference to the original function, even after you changed the name reference to another function.

My 2 cents: find real performance issues to optimize.

edited Jun 10, 2015 at 18:03

answered Jun 10, 2015 at 15:37

u.k

3,0911 gold badge22 silver badges23 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Muhammad Bilal · Accepted Answer · 2015-06-10 15:43:33Z

0

I think you can create custom event and attached to the caller. You can remove the event from caller based on any condition you want.

answered Jun 10, 2015 at 15:43

Muhammad Bilal

1493 bronze badges

Collectives™ on Stack Overflow

Dynamically changing javascript function for efficiency

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related