trying to call my function from a click event JS/jQuery

Question

I have a button; when I click the button I want my function to get a random image (using colors temporarily) I know the code in my function works, but when I try to call the function from the .click event the function doesn't seem to work any help would be greatly appreciated.

function getRandomImage() {
  if ($("#imageContainer").css("background-color", "black") == $("#imageContainer").css("background-color", "black")) {
    $("#imageContainer").css("background-color", "red");
  }
}

$("#mainButton").click(function(){
getRandomImage();
});

I know I'm missing something/doing something off, please help :)

What does the console logs say? Any errors?

Jite
– Jite

2015-06-09 17:05:13 +00:00
Commented Jun 9, 2015 at 17:05 — Jite
– Jite, Commented Jun 9, 2015 at 17:05

jwatts1980 · Accepted Answer · 2015-06-09 17:03:01Z

You need to make sure that your jQuery code is wrapped in a document ready like so:

<script>
    function getRandomImage() {
      if ($("#imageContainer").css("background-color", "black") == $("#imageContainer").css("background-color", "black")) {
        $("#imageContainer").css("background-color", "red");
      }
    }

    $(document).ready(function() {
        $("#mainButton").click(function(){
            getRandomImage();
        });
    });
</script>

Also, since you didn't show the HTML, you need to make sure that the ID attribute is set:

<input type="button" id="mainButton" />

JQuery selectors (like your #mainButton) immediately search the document model to find the element to attach the event to. If you call the jQuery code before the document has loaded, it will likely not find the element because it doesn't exist yet. So you use the document ready to ensure the jQuery code runs after all the elements have loaded into the DOM.

Rino Raj · Accepted Answer · 2015-06-09 17:04:57Z

0

Please try writing the click event inside document.ready()

    $(document).ready(function(){
        $("#mainButton").click(function(){
            getRandomImage();
         });
    });

Ouside document.ready() you should write the function

 function getRandomImage() {
  if ($("#imageContainer").css("background-color", "black") == $("#imageContainer").css("background-color", "black")) {
    $("#imageContainer").css("background-color", "red");
  }
}

Else you can directly call the function from the button.

<input type="button" onClick="getRandomImage()" id="mainButton" />

answered Jun 9, 2015 at 17:04

Rino Raj

6,2622 gold badges29 silver badges44 bronze badges

Comments

Abhishekh Gupta · Accepted Answer · 2015-06-09 17:14:21Z

0

You can try this:

function getRandomImage() {
    if ($("#imageContainer").css("background-color") == "rgb(0, 0, 0)") {
        $("#imageContainer").css("background-color", "red");
      }
    }

$(document).ready(function() {
    $("#mainButton").click(function(){
        getRandomImage();
    });
});

edited Jun 9, 2015 at 17:14

answered Jun 9, 2015 at 17:09

Abhishekh Gupta

6,2464 gold badges20 silver badges49 bronze badges

Comments

VanHartman · Accepted Answer · 2015-06-09 17:22:34Z

0

thank you all very much, I brain lapsed this worked best for me but again thank you all!

    $(document).ready(function(){
        $("#mainButton").click(function(){
            getRandomImage();
         });
    });
Ouside document.ready() you should write the function

 function getRandomImage() {
  if ($("#imageContainer").css("background-color", "black") == $("#imageContainer").css("background-color", "black")) {
    $("#imageContainer").css("background-color", "red");
  }
}
Else you can directly call the function from the button.

<input type="button" onClick="getRandomImage()" id="mainButton" />

answered Jun 9, 2015 at 17:22

VanHartman

272 bronze badges

Collectives™ on Stack Overflow

trying to call my function from a click event JS/jQuery

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related