NodeJs MongoDB Nested Queries - Run Callback Synchronously

Question

I have a code block like below. I could not find how to achieve that.
- I have rooms collection in mongodb and documents in this collection include user id array. Each room can have multiple users.
- So I want to find that usernames which are in the rooms that include my user Id.

DB collections:
Rooms {roomId:1, users:[99, 100]}, {roomId:2, users:[99, 101]}
Users {_id:99, name:"Alex"},{_id:100, name:"Harry"},{_id:101, name:"Tom"}

var userId = 99;
var arrUserIds = [];
var arrRooms = [];
var strUserNames = "";
db.collection("rooms").find({"users.userId":userId}).toArray(function(err, rooms) {

    for (var i=0; i<rooms.length; i++) {
        arrUserIds = [];

        for(var j=0; j<rooms[i].users.length; j++){
            arrUserIds.push(new BSON.ObjectID(rooms[i].users[j].userId));   
        }

        db.collection('users').find({"_id": {$in: arrUserIds}}).toArray(function(err, users) {
            strUserNames = users.map(function(elem){return elem.name;}).join(", ");
            arrRooms.push({_id:rooms[i].roomId, name:strUserNames });
        });

    }

    res.json({rooms:arrRooms});
});

I want to have a result like that:
arrRooms: [ { _id:1:, name:"Alex, Harry" }, { _id:2:, name:"Alex, Tom" } ]

Thanks

Mark Hughes · Accepted Answer · 2015-06-02 12:41:51Z

1

You're returning res.json before the second .find callback executes, so it will be empty. You need to restructure to wait for all the async callbacks before responding, like so:

var userId = 99;
var arrRooms = [];
var strUserNames = "";

db.collection("rooms").find({"users.userId":userId}).toArray(function(err, rooms) {

    var completed = 0;
    var complete = function() {
        completed++;
        if (completed === rooms.length - 1) {
            res.json({rooms:arrRooms});
        }
    }


    for (var i=0; i<rooms.length; i++) {
        var arrUserIds = [];
        var roomId = rooms[i].roomId;

        for(var j=0; j<rooms[i].users.length; j++){
            arrUserIds.push(new BSON.ObjectID(rooms[i].users[j].userId));   
        }

        db.collection('users').find({"_id": {$in: arrUserIds}}).toArray(function(err, users) {
            strUserNames = users.map(function(elem){return elem.name;}).join(", ");
            arrRooms.push({_id:roomId, name:strUserNames });

            complete();
        });
    }

});

edited Jun 2, 2015 at 12:41

answered Jun 2, 2015 at 10:05

Mark Hughes

7,4042 gold badges36 silver badges37 bronze badges

Sign up to request clarification or add additional context in comments.

7 Comments

baris usanmaz Over a year ago

I want to have a result like that: arrRooms: [{_id:1:, name:"Alex, Harry" },{_id:2:, name:"Alex, Tom" }] But your answer does not give me this result. I need to run second .find callback synchronously.

Mark Hughes Over a year ago

Ah, I see - I'll have another go.

Mark Hughes Over a year ago

@barisusanmaz Updated - does that cover it?

baris usanmaz Over a year ago

No, I am sorry it does not work. That gives me only last room information in 3 rooms.

Mark Hughes Over a year ago

@barisusanmaz one last try, I've just updated the answer; resetting the arrUserIds array inside the for loop.

|

Collectives™ on Stack Overflow

NodeJs MongoDB Nested Queries - Run Callback Synchronously

1 Answer 1

7 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

7 Comments

Your Answer

Sign up or log in

Post as a guest

Related