Adding dynamic variables to an array

Question

    foreach ( $tbl_one_data as $row_ ) {
        $id = ( int ) $row_ [0];
        $time = mysql_real_escape_string ( $row_ [1] );
        $callid = mysql_real_escape_string ( $row_ [2] );
        $queuename = mysql_real_escape_string ( $row_ [3] );

        $arrayValues [] = "($id, '$time','$callid','$queuename',";
    }
}

I am trying to improve the above code with the code below:

$b = 0;
        foreach ( $tbl_one_data as $row_ ) {
            if ($b < count ( $row_ )) {
                ${"var" . $b} = mysql_escape_string ( $row_ [$b] );
                $b ++;
            }
        }

My question is how would I add the dynamic variables created into the array incrementally to achieve something like this: $arrayValues [] = "('$var0','$var1','$var2','$var3'"; ??

$arrayValues [] = "('${"var" . $b}',"; doesn't seem to have the same effect as in my first code snippet.

Also, move away from mysql_ functions and use mysqli_ or move in to OO PHP with PDO . MySQL_ funtions are deprecated and should no longer be used. — Mm-Art-In
– Mm-Art-In, Commented May 7, 2015 at 15:17

fbas · Accepted Answer · 2015-05-07 14:54:47Z

1

I believe this is what you're asking for:

foreach ( $tbl_one_data as $row_ ) {
    $arrayValues [] = "('" . implode("','", $row_) . ",";
}

All the elements in $row_ are concatenated together into a string by implode() using a comma and single quotes as the "glue".

If this doesn't help or isn't what you wanted, leave a comment and we'll try to get better feedback.

answered May 7, 2015 at 14:54

fbas

1,6843 gold badges17 silver badges26 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

b0w3rb0w3r Over a year ago

Surprisingly simple but very effective. Thanks.

FatalError · Accepted Answer · 2015-05-07 14:47:25Z

0

You can make it simply by using below code:

foreach ( $tbl_one_data as $row_ ) {
    $newArr = array();
    $newArr[] = ( int ) $row_ [0];
    $newArr[] = mysql_real_escape_string ( $row_ [1] );
    $newArr[] = mysql_real_escape_string ( $row_ [2] );
    $newArr[] = mysql_real_escape_string ( $row_ [3] );

    $arrayValues [] = $newArr;
}

answered May 7, 2015 at 14:47

FatalError

5502 silver badges18 bronze badges

Collectives™ on Stack Overflow

Adding dynamic variables to an array

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related