PHP: Run function on multiple strings

Question

I am currently using rtrim() to remove trailing newlines from strings. Is there a more efficient way to run the following commands?

$a = rtrim($a);
$b = rtrim($b);
...
$z = rtrim($z);

(Note, $a .. $z are just placeholders, they're not the real variable names)

These variables are being created through the following function

foreach ($xml->xpath('//hardware') as $hwprofile) {
        $machine .= $hwprofile->machine . "\n";
        $count .= $hwprofile->ProcessorInfo->count . "\n";
        $speed .= $hwprofile->ProcessorInfo->speed . "\n";
        $type .= $hwprofile->ProcessorInfo->type . "\n";
        $arch .= $hwprofile->ProcessorInfo->architecture . "\n";
}

I want to trim those variables because they all have trailing newlines

put the strings into an array and use array_map / array_walk :) — Marc
– Marc, Commented Apr 29, 2015 at 18:52
Is that more efficient? Even if it is, it won't be by much :P — Jonnix
– Jonnix, Commented Apr 29, 2015 at 18:54
I guess it won't be more efficient but I am looking to keep my code short — Bijan
– Bijan, Commented Apr 29, 2015 at 18:55
Where are $a, $b, etc. coming from, and what are you doing with them? I think this will influence how they could be handled more efficiently. — Don't Panic
– Don't Panic, Commented Apr 29, 2015 at 18:56

Rizier123 · Accepted Answer · 2015-04-29 19:17:31Z

6

This should work for you:

Just fill the array $items with your variable names. Then it loops through all variables and with variable variables and rtim's them.

$items = range("a", "z"); //your variable names e.g. $items = ["machine", "count"]

foreach($items as $item) {
    $$item = rtrim($$item);
}

Another variant which you could also use, since you said you need a new line between every line expect the last one, just create an array like this:

foreach ($xml->xpath('//hardware') as $hwprofile) {
        $machine[] = $hwprofile->machine;
        $count[] = $hwprofile->ProcessorInfo->count;
        $speed[] = $hwprofile->ProcessorInfo->speed;
        $type[] = $hwprofile->ProcessorInfo->type;
        $arch[] = $hwprofile->ProcessorInfo->architecture;
}

And if you need it now just use:

implode(PHP_EOL, $machine);

edited Apr 29, 2015 at 19:17

answered Apr 29, 2015 at 18:56

Rizier123

59.8k17 gold badges106 silver badges167 bronze badges

Sign up to request clarification or add additional context in comments.

7 Comments

SaidbakR Over a year ago

@PedroLobito I think that it is optional if you used foreach(): ... endforeach;

Rizier123 Over a year ago

@sємsєм No it's "always" optional if you don't put bracket just the next expression is in the foreach loop (e.g. foreach(range(1, 10) as $v); <- See the semicolon that gets "executed" 10 times)

Alejandro Iván Over a year ago

This is to make the process "easier", but in what way is this more efficient? It uses more resources.

SaidbakR Over a year ago

You are right I have made this demo and it works without brackets.

Rizier123 Over a year ago

@AlejandroIván If you are asking what is more efficient with the foreach loop with or without brackets, then the answer is both are the same.

|

Stephen · Accepted Answer · 2015-04-29 19:17:48Z

0

So I think a cleaner solution is that instead of appending strings in each iteration, and then trimming, you could do the following:

The variables that are currently strings and appended each time become arrays. For each iteration, append the values to the appropriate array without the new line character.

When you need to use the value call implode("\n", $array) and it will join the values with a newline or whatever other separator you choose

answered Apr 29, 2015 at 19:17

Stephen

19k4 gold badges35 silver badges33 bronze badges

Comments

Alejandro Iván · Accepted Answer · 2015-04-29 19:23:49Z

0

The most efficient way of removing those trailing newlines is to do it inside the function (foreach loop in your case) that generates it.

Processing them after being created uses more resources (memory allocations, interpretation, change values from a variable, etc).

If you want to make the processing easier to write, then the other answers should be fine.

Don't confuse efficiency (which is making a function to process something in a better/less expensive way) with cleaner/easier to write code.

answered Apr 29, 2015 at 19:23

Alejandro Iván

4,0611 gold badge23 silver badges31 bronze badges

Collectives™ on Stack Overflow

PHP: Run function on multiple strings

3 Answers 3

7 Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

7 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related