javascript - onchange/onclick function not working on checkbox

Question

I am trying to trigger onclick function by checkbox and link. Here is Demo which works fine. But If I make change by writing onclick/onchange inside checkbox its not working.:

<input type="checkbox" id="mycheckbox" onclick="myChange();"/>

If I call like this then it works fine:

<input type="checkbox" id="mycheckbox">

document.getElementById('mycheckbox').onclick = function(){
 myChange();
};

Not working :( I wanted to work in Javascript only. Not Jquery What is the reason myChange() not being called from inside input tag

what do you mean by not working ?? what happens when you click on checkbox — user7789076
– user7789076, Commented Apr 14, 2015 at 10:19
Your code should work fine, it may be something related with JSFiddle. You can see your code working fine here — chiapa
– chiapa, Commented Apr 14, 2015 at 10:41

ketan · Accepted Answer · 2015-04-14 10:33:48Z

1

Check Here your updated code works.

    function myChange(){
    var temp = document.getElementById('mycheckbox');
    document.getElementById('container').style.display = temp.checked ? 'block' : 'none';
};



document.getElementById('loginlink').onclick = function(){
if (document.getElementById('mycheckbox').checked) {
     document.getElementById('mycheckbox').checked = false ;
     myChange();
} else {
document.getElementById('mycheckbox').checked = true ;
    myChange();
}
  
}

#container {
    display: none;
}

<div id="container">Check Box is Checked</div>
<br><br>
<label>
    <input type="checkbox" id="mycheckbox" onclick="myChange()"/>
    Show/hide
    <a href="javascript:void(0)" id="loginlink" >Click Me</a>

</label>

Check Fiddle.

edited Apr 14, 2015 at 10:33

answered Apr 14, 2015 at 10:25

ketan

19.4k42 gold badges68 silver badges107 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Hetal Khunti Over a year ago

Thanks this is what I was looking for. But Why you have put script tag in html tab?

ketan Over a year ago

In JSFiddle that way it is working. I don't know much about JSFiddle.

Hetal Khunti Over a year ago

Ok let me check this works in my project this way or not

Collectives™ on Stack Overflow

javascript - onchange/onclick function not working on checkbox

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related