Function method in object in Javascript

Question

I am working on a Javascript object exercise. My output is not what I expected. Please take a look at my code and give some advise. Here is the code:

function myFunction(name) {
  this.name = name;
  this.models = new Array();
  this.add = function (brand){ 
    this.models =  brand;
  };
}
var c = new myFunction ("pc");
c.add("HP");
c.add("DELL");
console.log(c.models);

The output is "DELL"

My expected output is ["HP","DELL"]

Thank you so much for your help!

a multiple argument version: this.add=[].push.bind(this.models); — dandavis
– dandavis, Commented Mar 27, 2015 at 5:00

generic andy · Accepted Answer · 2015-03-27 04:46:49Z

3

Change the add function. You want to push the brand into the model. Not set the model to it.

this.add = function (brand){ 
    this.models.push(brand);
};

answered Mar 27, 2015 at 4:46

generic andy

1411 silver badge5 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

GregL · Accepted Answer · 2015-03-27 04:46:37Z

1

To add something to an array, you should use the .push() method.

Change your code to:

function myFunction(name) {
  this.name = name;
  this.models = new Array();
  this.add = function (brand){ 
    this.models.push(brand);
  };
}

P.S. It is customary to name such constructor type of functions starting with a capital letter.

answered Mar 27, 2015 at 4:46

GregL

38.2k8 gold badges65 silver badges68 bronze badges

Collectives™ on Stack Overflow

Function method in object in Javascript

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related