javascript function in html form

Question

I have seen some other threads like this but they don't seem to help me in my problem. I am new to Javascript and I am struggling to understand which value in the email input has to be called in my javascript function to make it work.

<input type="email" name="myEmail"  value="" class="form-control" required placeholder="Please Enter your email" maxlength="50">

The function I am using is this:

function check_v_mail('myEmail') {
    fld_value = document.getElementById(field).value;
    is_m_valid = 0;
    if (fld_value.indexOf('@') >= 1) {
        m_valid_dom = fld_value.substr(fld_value.indexOf('@')+1);
        if (m_valid_dom.indexOf('@') == -1) {
            if (m_valid_dom.indexOf('.') >= 1) {
                m_valid_dom_e = m_valid_dom.substr(m_valid_dom.indexOf('.')+1);
                if (m_valid_dom_e.length >= 1) {
                    is_m_valid = 1;
                }
            }
        }
    }
    if (is_m_valid) {
        update_css_class(field, 2);
        m_valid_r = 1;
    } else {
        update_css_class(field, 1);
        m_valid_r = 0;
    }
    return m_valid_r;
}

This function is saved as email_script.js and is called in my footer as follows:

<script src="includes/js/email_script.js"></script>

What am I doing wrong?

mti2935 · Accepted Answer · 2015-03-18 00:51:58Z

1

You need to call the check_v_mail function. Usually, this is done when the user clicks the button to submit the form.

answered Mar 18, 2015 at 0:51

mti2935

12.1k4 gold badges32 silver badges34 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Polynomial Proton · Accepted Answer · 2015-03-18 00:53:43Z

0

<form name="myForm" onsubmit="return check_v_mail('myEmail')" method="post">
Email: <input type="email" name="myEmail"  value="" class="form-control" required placeholder="Please Enter your email" maxlength="50">
<input type="submit" value="Submit">
</form>

You can add it in form's onsubmit

answered Mar 18, 2015 at 0:53

Polynomial Proton

5,18023 silver badges37 bronze badges

4 Comments

coolrider Over a year ago

Ah that makes sense but don't i have to add a parameter in 'check_v_mail(parameter)' ?

Polynomial Proton Over a year ago

Also you can use getElementByName since you have the name as 'myEmail'

coolrider Over a year ago

onsubmit="return check_v_mail('MyEmail')" <input type="email" name="myEmail" id="MyEmail" value="" class="form-control" I tried this but still no success any idea?

Polynomial Proton Over a year ago

check this jsbin : jsbin.com/punadereva/1/edit it works fine.Which means error is in your javascript function which I havent checked yet

kodebot · Accepted Answer · 2015-03-18 00:57:39Z

0

In addition to calling the function on form submit or field exit, you also need to add id attribute to your element because your function uses getElementById() to get the element but your input element doesn't have id attribute

<input type="email" name="myEmail"  id ="myEmail" value="" class="form-control" required placeholder="Please Enter your email" maxlength="50">

answered Mar 18, 2015 at 0:57

kodebot

1,7881 gold badge22 silver badges31 bronze badges

2 Comments

coolrider Over a year ago

I added a id="MyEmail" in the email input line, --- I also called it like that onsubmit="return check_v_mail('MyEmail') - but still it doesnt seem to work

kodebot Over a year ago

@coolrider: change your function from function check_v_mail('myEmail') to function check_v_mail(field)

RainingChain · Accepted Answer · 2015-03-18 03:32:02Z

To expand on a comment by Mani:

Right now the signature of your function check_v_mail is incorrect, it is written like a call to a function.

Signature in email_script.js could be:

function check_v_mail(emailFieldId) {
   fld_value = document.getElementById(emailFieldId).value;

   return m_valid_r;
}

Calling on the form could be:

<form onsubmit="return check_v_mail('myEmail');" method="post"></form>

A slight tweak is to have a validate function or class that handles the validation. This can be expanded to call multiple different validation methods and decreases the likelihood that the onsubmit will become complex with additional validations.

<form onsubmit="return validateForm();" method="post"></form>

function validateForm() {
    var emailValid = check_v_mail('myEmail')
    var firstNameValid = validateFirstName('firstNameInput');

    return emailValid && firstNameValid;
}

Collectives™ on Stack Overflow

javascript function in html form

4 Answers 4

Comments

4 Comments

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

4 Comments

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related